Factory methods for heap-allocated SkMaskFilter objects.

include/effects/SkEmbossMaskFilter.h

 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkEmbossMaskFilter_DEFINED
 #define SkEmbossMaskFilter_DEFINED
 
 #include "SkMaskFilter.h"
 
 /** \class SkEmbossMaskFilter
 
     This mask filter creates a 3D emboss look, by specifying a light and blur amount.
 */
 class SK_API SkEmbossMaskFilter : public SkMaskFilter {
 public:
     struct Light {
         SkScalar    fDirection[3];  // x,y,z
         uint16_t    fPad;
         uint8_t     fAmbient;
         uint8_t     fSpecular;      // exponent, 4.4 right now
     };
 
-    SkEmbossMaskFilter(SkScalar blurSigma, const Light& light);
+    static SkEmbossMaskFilter* Create(SkScalar blurSigma, const Light& light) {
+        return SkNEW_ARGS(SkEmbossMaskFilter, (blurSigma, light));
+    }
 
     SK_ATTR_DEPRECATED("use sigma version")
-    SkEmbossMaskFilter(const Light& light, SkScalar blurRadius);
+    static SkEmbossMaskFilter* Create(const Light& light, SkScalar blurRadius) {

[scroggo, 2014/02/20 14:17:07]

No need to create a factory for the deprecated constructor. I think the only
caller of this is in src/views/SkWidgets.cpp (in Skia; Chrome and Android do not
call it at all), which we should update to use the new version.

[Dominik Grewe, 2014/02/20 16:38:11]

Done.

+        return SkNEW_ARGS(SkEmbossMaskFilter, (light, blurRadius));
+    }
 
     // overrides from SkMaskFilter
     //  This method is not exported to java.
     virtual SkMask::Format getFormat() const SK_OVERRIDE;
     //  This method is not exported to java.
     virtual bool filterMask(SkMask* dst, const SkMask& src, const SkMatrix&,
                             SkIPoint* margin) const SK_OVERRIDE;
 
     SkDEVCODE(virtual void toString(SkString* str) const SK_OVERRIDE;)
     SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkEmbossMaskFilter)
 
 protected:
     SkEmbossMaskFilter(SkReadBuffer&);
     virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;
 
+#ifdef SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS
+public:
+#endif
+    SkEmbossMaskFilter(SkScalar blurSigma, const Light& light);
+    SkEmbossMaskFilter(const Light& light, SkScalar blurRadius);

[scroggo, 2014/02/20 14:17:07]

This constructor can be removed entirely (once you update
src/views/SkWidgets.cpp).

[Dominik Grewe, 2014/02/20 16:38:11]

Done.

+
 private:
     Light       fLight;
     SkScalar    fBlurSigma;
 
     typedef SkMaskFilter INHERITED;
 };
 
 #endif