samplecode/SampleEmboss.cpp - Issue 173633003: Factory methods for heap-allocated SkMaskFilter objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samplecode/SampleEmboss.cpp

Issue 173633003: Factory methods for heap-allocated SkMaskFilter objects. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add SkTableMaskFilter::Create(table) and remove deprecated SkEmbossMaskFilter constructor. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samplecode/SampleEmboss.cpp

diff --git a/samplecode/SampleEmboss.cpp b/samplecode/SampleEmboss.cpp

index dacd4bfd2fa0cee713643dec794a26bdb2e15e15..1810a09f767c48d66d20f97ea405d7f0f39de8d4 100644

--- a/samplecode/SampleEmboss.cpp

+++ b/samplecode/SampleEmboss.cpp

@@ -53,7 +53,7 @@ protected:

paint.setAntiAlias(true);

paint.setStyle(SkPaint::kStroke_Style);

paint.setStrokeWidth(SkIntToScalar(10));

- paint.setMaskFilter(new SkEmbossMaskFilter(

+ paint.setMaskFilter(SkEmbossMaskFilter::Create(

SkBlurMask::ConvertRadiusToSigma(SkIntToScalar(4)), fLight))->unref();

paint.setShader(new SkColorShader(SK_ColorBLUE))->unref();

paint.setDither(true);

« no previous file with comments | « samplecode/SampleAll.cpp ('k') | src/effects/SkEmbossMaskFilter.cpp » ('j') | no next file with comments »