Factory methods for heap-allocated SkMaskFilter objects.

include/effects/SkTableMaskFilter.h

 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkTableMaskFilter_DEFINED
 #define SkTableMaskFilter_DEFINED
 
 #include "SkMaskFilter.h"
 #include "SkScalar.h"
 
 /** \class SkTableMaskFilter
 
     Applies a table lookup on each of the alpha values in the mask.
     Helper methods create some common tables (e.g. gamma, clipping)
  */
 class SK_API SkTableMaskFilter : public SkMaskFilter {
 public:
-    SkTableMaskFilter();
-    SkTableMaskFilter(const uint8_t table[256]);
     virtual ~SkTableMaskFilter();
 
     /** Utility that sets the gamma table
      */
     static void MakeGammaTable(uint8_t table[256], SkScalar gamma);
 
     /** Utility that creates a clipping table: clamps values below min to 0
         and above max to 255, and rescales the remaining into 0..255
      */
     static void MakeClipTable(uint8_t table[256], uint8_t min, uint8_t max);
@@ skipping 14 matching lines @@
     virtual bool filterMask(SkMask*, const SkMask&, const SkMatrix&,
                             SkIPoint*) const SK_OVERRIDE;
 
     SkDEVCODE(virtual void toString(SkString* str) const SK_OVERRIDE;)
     SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkTableMaskFilter)
 
 protected:
     SkTableMaskFilter(SkReadBuffer& rb);
     virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;
 
+#ifdef SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS
+public:
+#endif
+    SkTableMaskFilter();
+    SkTableMaskFilter(const uint8_t table[256]);

[scroggo, 2014/02/20 14:17:07]

Please add a factory for this constructor, which is called by Android.

[Dominik Grewe, 2014/02/20 16:38:11]

Good spot, thanks. I just assumed everyone only used the provided factory
methods.

+
 private:
     uint8_t fTable[256];
 
     typedef SkMaskFilter INHERITED;
 };
 
 #endif