Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1734483002: Remove dead code related to Web Audio doppler effects (Closed)

Created:
4 years, 10 months ago by philipj_slow
Modified:
4 years, 10 months ago
Reviewers:
Raymond Toy
CC:
chromium-reviews, blink-reviews, hongchan, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead code related to Web Audio doppler effects Doppler already has no effect on AudioBufferSourceNodes, as the only call to setPannerNode was removed in time for M41: https://codereview.chromium.org/783273002/ PannerHandler::dopplerRate becomes unreachable next, and pulling at the thread of unreachable things ends up removing quite a lot. PannerNode's setVelocity is revealed to have no effect at all, although it remains in the spec. A spec issue was filed: https://github.com/WebAudio/web-audio-api/issues/730 BUG=439644 R=rtoy@chromium.org Committed: https://crrev.com/bf4835ab1d920f16f179229771cd9635b803d28e Cr-Commit-Position: refs/heads/master@{#377507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -180 lines) Patch
M third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h View 2 chunks +3 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp View 6 chunks +1 line, -34 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioListener.h View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioListener.cpp View 3 chunks +4 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PannerNode.h View 6 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PannerNode.cpp View 8 chunks +3 lines, -86 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
philipj_slow
4 years, 10 months ago (2016-02-24 07:02:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734483002/1
4 years, 10 months ago (2016-02-24 07:03:40 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 08:10:42 UTC) #5
Raymond Toy
lgtm. Thanks for removing all of this code!
4 years, 10 months ago (2016-02-24 19:41:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734483002/1
4 years, 10 months ago (2016-02-25 04:24:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 04:35:49 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 04:36:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf4835ab1d920f16f179229771cd9635b803d28e
Cr-Commit-Position: refs/heads/master@{#377507}

Powered by Google App Engine
This is Rietveld 408576698