Chromium Code Reviews
DescriptionRemove dead code related to Web Audio doppler effects
Doppler already has no effect on AudioBufferSourceNodes, as the only
call to setPannerNode was removed in time for M41:
https://codereview.chromium.org/783273002/
PannerHandler::dopplerRate becomes unreachable next, and pulling at the
thread of unreachable things ends up removing quite a lot.
PannerNode's setVelocity is revealed to have no effect at all, although
it remains in the spec. A spec issue was filed:
https://github.com/WebAudio/web-audio-api/issues/730
BUG=439644
R=rtoy@chromium.org
Committed: https://crrev.com/bf4835ab1d920f16f179229771cd9635b803d28e
Cr-Commit-Position: refs/heads/master@{#377507}
Patch Set 1 #
Messages
Total messages: 11 (4 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||