Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h

Issue 1734483002: Remove dead code related to Web Audio doppler effects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h
index d1c085e03aa5568e57338d646041fd6de2bffa44..8b355ba1af854166780918560ec63510c27eb731 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h
+++ b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h
@@ -79,16 +79,9 @@ public:
void setLoopStart(double loopStart) { m_loopStart = loopStart; }
void setLoopEnd(double loopEnd) { m_loopEnd = loopEnd; }
- // If a panner node is set, then we can incorporate doppler shift into the playback pitch rate.
- void setPannerNode(PannerHandler*);
- void clearPannerNode();
-
// If we are no longer playing, propogate silence ahead to downstream nodes.
bool propagatesSilence() const override;
- // AudioScheduledSourceNode
- void finish() override;
-
void handleStoppableSourceNode();
private:
@@ -137,23 +130,11 @@ private:
// True if grainDuration is given explicitly (via 3 arg start method).
bool m_isDurationGiven;
- // Compute playback rate (k-rate) by incorporating the sample rate conversion
- // factor, the doppler shift from the associated panner node, and the value
- // of playbackRate and detune AudioParams.
+ // Compute playback rate (k-rate) by incorporating the sample rate
+ // conversion factor, and the value of playbackRate and detune AudioParams.
double computePlaybackRate();
- // We optionally keep track of a panner node which has a doppler shift that
- // is incorporated into the pitch rate.
- // This RefPtr is connection reference. We must call AudioHandler::
- // makeConnection() after ref(), and call AudioHandler::breakConnection()
- // before deref().
- // TODO(tkent): This is always null because setPannerNode is never
- // called. If we revive setPannerNode, this should be a raw pointer and
- // AudioBufferSourceNode should have Member<PannerNode>.
- RefPtr<PannerHandler> m_pannerNode;
-
- // The minimum playbackRate value ever used for this source. This includes any adjustments
- // caused by doppler too.
+ // The minimum playbackRate value ever used for this source.
double m_minPlaybackRate;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698