Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioListener.cpp

Issue 1734483002: Remove dead code related to Web Audio doppler effects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioListener.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioListener.cpp b/third_party/WebKit/Source/modules/webaudio/AudioListener.cpp
index 23509ee634c47daa582e080230c19c2b19c64ec3..8521b8c4f570004c1ce3109635e842e46aa9c2b8 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioListener.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioListener.cpp
@@ -38,7 +38,6 @@ AudioListener::AudioListener()
: m_position(0, 0, 0)
, m_orientation(0, 0, -1)
, m_upVector(0, 1, 0)
- , m_velocity(0, 0, 0)
, m_dopplerFactor(1)
, m_speedOfSound(343.3)
{
@@ -96,7 +95,7 @@ void AudioListener::setPosition(const FloatPoint3D& position)
// This synchronizes with panner's process().
MutexLocker listenerLocker(m_listenerLock);
m_position = position;
- markPannersAsDirty(PannerHandler::AzimuthElevationDirty | PannerHandler::DistanceConeGainDirty | PannerHandler::DopplerRateDirty);
+ markPannersAsDirty(PannerHandler::AzimuthElevationDirty | PannerHandler::DistanceConeGainDirty);
}
void AudioListener::setOrientation(const FloatPoint3D& orientation)
@@ -121,38 +120,20 @@ void AudioListener::setUpVector(const FloatPoint3D& upVector)
markPannersAsDirty(PannerHandler::AzimuthElevationDirty);
}
-void AudioListener::setVelocity(const FloatPoint3D& velocity)
+void AudioListener::setVelocity(float x, float y, float z)
{
- if (m_velocity == velocity)
- return;
-
- // This synchronizes with panner's process().
- MutexLocker listenerLocker(m_listenerLock);
- m_velocity = velocity;
- markPannersAsDirty(PannerHandler::DopplerRateDirty);
+ // The velocity is not used internally and cannot be read back by scripts,
+ // so it can be ignored entirely.
}
void AudioListener::setDopplerFactor(double dopplerFactor)
{
- if (m_dopplerFactor == dopplerFactor)
- return;
-
- // This synchronizes with panner's process().
- MutexLocker listenerLocker(m_listenerLock);
m_dopplerFactor = dopplerFactor;
- markPannersAsDirty(PannerHandler::DopplerRateDirty);
}
void AudioListener::setSpeedOfSound(double speedOfSound)
{
- if (m_speedOfSound == speedOfSound)
- return;
-
- // This synchronizes with panner's process().
- MutexLocker listenerLocker(m_listenerLock);
m_speedOfSound = speedOfSound;
- markPannersAsDirty(PannerHandler::DopplerRateDirty);
}
} // namespace blink
-
« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AudioListener.h ('k') | third_party/WebKit/Source/modules/webaudio/PannerNode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698