Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 783273002: Remove Doppler effect from PannerNode (Closed)

Created:
6 years ago by Raymond Toy
Modified:
6 years ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove Doppler effect from PannerNode The W3C audio group has decided to remove the Doppler effect. In addition, the current PannerNode will eventually be deprecated in favor of new panner nodes (StereoPannerNode and future ones). (See https://github.com/WebAudio/web-audio-api/issues/372) The doppler effect was never done in a very general way and was only applied to AudioBufferSourceNodes, not Oscillators, or MediaStreams. (The effect was done by modifying the playback rate of the source node.) Multiple panner nodes also had strange effects if the velocity was different in each panner. This is not a complete removal of the code, but only the part that causes the source nodes to be modified with a new playback rate based on the doppler frequency of the panner. The remaining doppler code will be removed when the PannerNode is deprecated and finally removed. Bug 439644 tracks this. BUG=433798, 439644 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186738

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -59 lines) Patch
M Source/modules/webaudio/PannerNode.h View 3 chunks +0 lines, -8 lines 0 comments Download
M Source/modules/webaudio/PannerNode.cpp View 3 chunks +0 lines, -51 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Raymond Toy
PTAL.
6 years ago (2014-12-08 20:43:41 UTC) #2
Ken Russell (switch to Gerrit)
hoch@, could you please do the first round review of this CL? Thanks.
6 years ago (2014-12-08 21:11:18 UTC) #3
hongchan
On 2014/12/08 21:11:18, Ken Russell wrote: > hoch@, could you please do the first round ...
6 years ago (2014-12-08 21:38:11 UTC) #4
Ken Russell (switch to Gerrit)
On 2014/12/08 21:38:11, hoch wrote: > On 2014/12/08 21:11:18, Ken Russell wrote: > > hoch@, ...
6 years ago (2014-12-08 23:30:08 UTC) #5
Raymond Toy
On 2014/12/08 23:30:08, Ken Russell wrote: > On 2014/12/08 21:38:11, hoch wrote: > > On ...
6 years ago (2014-12-08 23:36:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783273002/1
6 years ago (2014-12-08 23:36:28 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-08 23:54:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186738

Powered by Google App Engine
This is Rietveld 408576698