Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: third_party/WebKit/Source/modules/webaudio/PannerNode.h

Issue 1734483002: Remove dead code related to Web Audio doppler effects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/PannerNode.h
diff --git a/third_party/WebKit/Source/modules/webaudio/PannerNode.h b/third_party/WebKit/Source/modules/webaudio/PannerNode.h
index c7050af72398a620ef6f7235ff839ee77f1a04e9..a12095ebb48de6c9a4025fd4f7f208b8211d8fe4 100644
--- a/third_party/WebKit/Source/modules/webaudio/PannerNode.h
+++ b/third_party/WebKit/Source/modules/webaudio/PannerNode.h
@@ -51,7 +51,6 @@ public:
enum {
AzimuthElevationDirty = 0x1,
DistanceConeGainDirty = 0x2,
- DopplerRateDirty = 0x4,
};
static PassRefPtr<PannerHandler> create(AudioNode&, float sampleRate);
@@ -66,10 +65,9 @@ public:
String panningModel() const;
void setPanningModel(const String&);
- // Position, orientation and velocity
+ // Position and orientation
void setPosition(float x, float y, float z);
void setOrientation(float x, float y, float z);
- void setVelocity(float x, float y, float z);
// Distance parameters
String distanceModel() const;
@@ -96,9 +94,6 @@ public:
void markPannerAsDirty(unsigned);
- // It must be called on audio thread, currently called only process() in AudioBufferSourceNode.
- double dopplerRate();
-
double tailTime() const override { return m_panner ? m_panner->tailTime() : 0; }
double latencyTime() const override { return m_panner ? m_panner->latencyTime() : 0; }
@@ -115,14 +110,12 @@ private:
void calculateAzimuthElevation(double* outAzimuth, double* outElevation);
float calculateDistanceConeGain(); // Returns the combined distance and cone gain attenuation.
- double calculateDopplerRate();
void azimuthElevation(double* outAzimuth, double* outElevation);
float distanceConeGain();
bool isAzimuthElevationDirty() const { return m_isAzimuthElevationDirty; }
bool isDistanceConeGainDirty() const { return m_isDistanceConeGainDirty; }
- bool isDopplerRateDirty() const { return m_isDopplerRateDirty; }
// This Persistent doesn't make a reference cycle including the owner
// PannerNode.
@@ -134,11 +127,9 @@ private:
// Current source location information
FloatPoint3D m_position;
FloatPoint3D m_orientation;
- FloatPoint3D m_velocity;
bool m_isAzimuthElevationDirty;
bool m_isDistanceConeGainDirty;
- bool m_isDopplerRateDirty;
// Gain
DistanceEffect m_distanceEffect;
@@ -149,7 +140,6 @@ private:
double m_cachedAzimuth;
double m_cachedElevation;
float m_cachedDistanceConeGain;
- double m_cachedDopplerRate;
// Synchronize process() with setting of the panning model, source's location information, listener, distance parameters and sound cones.
mutable Mutex m_processLock;

Powered by Google App Engine
This is Rietveld 408576698