Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 173133003: Convert garden-o-matic guts over to promises where appropriate (Closed)

Created:
6 years, 10 months ago by alecflett
Modified:
6 years, 10 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Convert garden-o-matic guts over to promises where appropriate This gets rid of all one-shot callbacks in favor of promises. There are a few "progress" style callbacks which don't need to be converted. R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167530

Patch Set 1 #

Total comments: 1

Patch Set 2 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -307 lines) Patch
M Tools/GardeningServer/scripts/base.js View 4 chunks +21 lines, -51 lines 0 comments Download
M Tools/GardeningServer/scripts/base_unittests.js View 1 chunk +0 lines, -55 lines 0 comments Download
M Tools/GardeningServer/scripts/builders.js View 3 chunks +22 lines, -23 lines 0 comments Download
M Tools/GardeningServer/scripts/builders_unittests.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Tools/GardeningServer/scripts/checkout.js View 2 chunks +22 lines, -26 lines 0 comments Download
M Tools/GardeningServer/scripts/checkout_unittests.js View 2 chunks +10 lines, -10 lines 0 comments Download
M Tools/GardeningServer/scripts/controllers.js View 1 chunk +1 line, -1 line 0 comments Download
M Tools/GardeningServer/scripts/garden-o-matic.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Tools/GardeningServer/scripts/model.js View 7 chunks +18 lines, -16 lines 0 comments Download
M Tools/GardeningServer/scripts/model_unittests.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/GardeningServer/scripts/results.js View 8 chunks +73 lines, -69 lines 0 comments Download
M Tools/GardeningServer/scripts/results_unittests.js View 5 chunks +23 lines, -16 lines 0 comments Download
M Tools/GardeningServer/scripts/rollbot.js View 1 chunk +6 lines, -8 lines 0 comments Download
M Tools/GardeningServer/scripts/rollbot_unittests.js View 1 chunk +1 line, -1 line 0 comments Download
M Tools/GardeningServer/scripts/svn-log.js View 1 chunk +3 lines, -9 lines 0 comments Download
M Tools/GardeningServer/scripts/svn-log_unittests.js View 1 chunk +1 line, -1 line 0 comments Download
M Tools/GardeningServer/scripts/ui.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Tools/GardeningServer/scripts/ui/results.js View 3 chunks +3 lines, -4 lines 0 comments Download
M Tools/GardeningServer/scripts/ui/results_unittests.js View 4 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
alecflett
More cleanup: this converts everything to promises. There are still a few things to clean ...
6 years, 10 months ago (2014-02-20 01:12:40 UTC) #1
abarth-chromium
LGTM Thanks for doing this! https://codereview.chromium.org/173133003/diff/1/Tools/GardeningServer/scripts/base.js File Tools/GardeningServer/scripts/base.js (left): https://codereview.chromium.org/173133003/diff/1/Tools/GardeningServer/scripts/base.js#oldcode159 Tools/GardeningServer/scripts/base.js:159: base.RequestTracker = function(requestsInFlight, callback, ...
6 years, 10 months ago (2014-02-20 06:18:51 UTC) #2
alecflett
The CQ bit was checked by alecflett@chromium.org
6 years, 10 months ago (2014-02-20 16:01:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/173133003/1
6 years, 10 months ago (2014-02-20 16:01:14 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-20 19:04:35 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=28173
6 years, 10 months ago (2014-02-20 19:04:36 UTC) #6
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 10 months ago (2014-02-20 19:10:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/173133003/1
6 years, 10 months ago (2014-02-20 19:10:35 UTC) #8
alecflett
6 years, 10 months ago (2014-02-20 19:46:47 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r167530 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698