Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1674)

Unified Diff: Tools/GardeningServer/scripts/ui/results.js

Issue 173133003: Convert garden-o-matic guts over to promises where appropriate (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: update to ToT Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/scripts/ui.js ('k') | Tools/GardeningServer/scripts/ui/results_unittests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/scripts/ui/results.js
diff --git a/Tools/GardeningServer/scripts/ui/results.js b/Tools/GardeningServer/scripts/ui/results.js
index d6979f22a098ee7ed3c6f25ad1f3de858c1d90f9..be2ddf00820984b4f124e174cb173784da41172d 100644
--- a/Tools/GardeningServer/scripts/ui/results.js
+++ b/Tools/GardeningServer/scripts/ui/results.js
@@ -149,7 +149,6 @@ ui.results.ResultsGrid = base.extends('div', {
}
this.addComparison(resultType, resultsURLsByKind);
}.bind(this));
-
if (!this.children.length)
this.textContent = 'No results to display.'
}
@@ -167,7 +166,7 @@ ui.results.ResultsDetails = base.extends('div', {
if (this._haveShownOnce)
return;
this._haveShownOnce = true;
- this._delegate.fetchResultsURLs(this._failureInfo, function(resultsURLs) {
+ this._delegate.fetchResultsURLs(this._failureInfo).then(function(resultsURLs) {
var resultsGrid = new ui.results.ResultsGrid();
resultsGrid.addResults(resultsURLs);
@@ -432,9 +431,9 @@ ui.results.View = base.extends('div', {
this._testSelector = new ui.results.TestSelector(this, resultsByTest);
this.appendChild(this._testSelector);
},
- fetchResultsURLs: function(failureInfo, callback)
+ fetchResultsURLs: function(failureInfo)
{
- this._delegate.fetchResultsURLs(failureInfo, callback)
+ return this._delegate.fetchResultsURLs(failureInfo);
},
nextResult: function()
{
« no previous file with comments | « Tools/GardeningServer/scripts/ui.js ('k') | Tools/GardeningServer/scripts/ui/results_unittests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698