Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1822)

Unified Diff: Tools/GardeningServer/scripts/base_unittests.js

Issue 173133003: Convert garden-o-matic guts over to promises where appropriate (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: update to ToT Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/scripts/base.js ('k') | Tools/GardeningServer/scripts/builders.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/scripts/base_unittests.js
diff --git a/Tools/GardeningServer/scripts/base_unittests.js b/Tools/GardeningServer/scripts/base_unittests.js
index 3a69d0a25530dcdd1d3f8c056df0cb400608b4c4..fd14a4ce2d4ef51b27f7d0104f3e393aaa371ca4 100644
--- a/Tools/GardeningServer/scripts/base_unittests.js
+++ b/Tools/GardeningServer/scripts/base_unittests.js
@@ -80,61 +80,6 @@ test("flattenArray", 5, function() {
deepEqual(base.flattenArray([["a"], [], ["b"]]), ["a", "b"]);
});
-test("callInParallel", 4, function() {
- var expectedCall = [true, true, true];
- var expectCompletionCallback = true;
-
- base.callInParallel([
- function(callback) {
- ok(expectedCall[0]);
- expectedCall[0] = false;
- callback();
- },
- function(callback) {
- ok(expectedCall[1]);
- expectedCall[1] = false;
- callback();
- },
- function(callback) {
- ok(expectedCall[2]);
- expectedCall[2] = false;
- callback();
- },
- ], function() {
- ok(expectCompletionCallback);
- expectCompletionCallback = false;
- })
-});
-
-test("RequestTracker", 5, function() {
- var ready = false;
- var tracker = new base.RequestTracker(1, function() {
- ok(ready);
- });
- ready = true;
- tracker.requestComplete();
- ready = false;
-
- tracker = new base.RequestTracker(2, function(parameter) {
- ok(ready);
- equals(parameter, 'argument');
- }, ['argument']);
- tracker.requestComplete();
- ready = true;
- tracker.requestComplete();
- ready = false;
-
- tracker = new base.RequestTracker(0, function() {
- ok(true);
- });
- tracker.requestComplete();
-
- tracker = new base.RequestTracker(0);
- tracker.requestComplete();
- // Should not barf.
- ok(true);
-});
-
test("filterDictionary", 3, function() {
var dictionary = {
'foo': 43,
« no previous file with comments | « Tools/GardeningServer/scripts/base.js ('k') | Tools/GardeningServer/scripts/builders.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698