Tools/GardeningServer/scripts/controllers.js - Issue 173133003: Convert garden-o-matic guts over to promises where appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/GardeningServer/scripts/controllers.js

Issue 173133003: Convert garden-o-matic guts over to promises where appropriate (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: update to ToT Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Tools/GardeningServer/scripts/controllers.js

diff --git a/Tools/GardeningServer/scripts/controllers.js b/Tools/GardeningServer/scripts/controllers.js

index 5a6d07e353d15185065670b8517ff6837a989d0b..e73464e8cfa12e062b3cce3c15a179f28f496aa3 100644

--- a/Tools/GardeningServer/scripts/controllers.js

+++ b/Tools/GardeningServer/scripts/controllers.js

@@ -294,7 +294,7 @@ controllers.UnexpectedFailures = base.extends(FailureStreamController, {

onRollout: function(revision, testNameList)

{

- checkout.rollout(revision, ui.rolloutReasonForTestNameList(testNameList), $.noop, function() {

+ checkout.rollout(revision, ui.rolloutReasonForTestNameList(testNameList)).then($.noop, function() {

// FIXME: We should have a better error UI.

alert(kCheckoutUnavailableMessage);

});