Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2850)

Unified Diff: Tools/GardeningServer/scripts/garden-o-matic.js

Issue 173133003: Convert garden-o-matic guts over to promises where appropriate (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: update to ToT Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/scripts/controllers.js ('k') | Tools/GardeningServer/scripts/model.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/scripts/garden-o-matic.js
diff --git a/Tools/GardeningServer/scripts/garden-o-matic.js b/Tools/GardeningServer/scripts/garden-o-matic.js
index 7d8ccecd7f43cf1e1de262b8ab3811af45142c14..0b60f5d4096be5782612d06451e4820306dbb73a 100644
--- a/Tools/GardeningServer/scripts/garden-o-matic.js
+++ b/Tools/GardeningServer/scripts/garden-o-matic.js
@@ -78,12 +78,12 @@ function update()
g_info.add(updating);
- builders.buildersFailingNonLayoutTests(function(failuresList) {
+ builders.buildersFailingNonLayoutTests().then(function(failuresList) {
g_nonLayoutTestFailureBuilders.update(failuresList);
updatePartyTime();
});
- base.callInParallel([model.updateRecentCommits, model.updateResultsByBuilder], function() {
+ Promise.all([model.updateRecentCommits(), model.updateResultsByBuilder()]).then(function() {
if (g_failuresController)
g_failuresController.update();
@@ -92,7 +92,7 @@ function update()
model.analyzeUnexpectedFailures(function(failureAnalysis) {
updating.update('Analyzing test failures ... ' + ++numberOfTestsAnalyzed + ' tests analyzed.');
g_unexpectedFailuresController.update(failureAnalysis);
- }, function() {
+ }).then(function() {
updatePartyTime();
g_unexpectedFailuresController.purge();
« no previous file with comments | « Tools/GardeningServer/scripts/controllers.js ('k') | Tools/GardeningServer/scripts/model.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698