Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1731303002: [crankshaft] Remove useless HCallFunction instruction. (Closed)

Created:
4 years, 10 months ago by Igor Sheludko
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Remove useless HCallFunction instruction. Everything that HCallFunction does can be easily done using more general HCallWithDescriptor, so there's no need to have this dedicated instruction around. Committed: https://crrev.com/9015dd1c96e0a403559983a94e41adb686aa3d8d Cr-Commit-Position: refs/heads/master@{#34257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -771 lines) Patch
M src/crankshaft/arm/lithium-arm.h View 2 chunks +0 lines, -24 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 2 chunks +0 lines, -24 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +9 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 9 chunks +57 lines, -31 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 3 chunks +1 line, -45 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 2 chunks +0 lines, -24 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 2 chunks +0 lines, -24 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 2 chunks +0 lines, -24 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 2 chunks +0 lines, -24 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 2 chunks +0 lines, -24 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 2 chunks +0 lines, -24 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 2 chunks +0 lines, -30 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731303002/1
4 years, 10 months ago (2016-02-24 14:51:55 UTC) #3
Igor Sheludko
PTAL
4 years, 10 months ago (2016-02-24 14:55:00 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 15:11:27 UTC) #7
Benedikt Meurer
Awesome Igor! LGTM.
4 years, 10 months ago (2016-02-24 17:49:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731303002/1
4 years, 10 months ago (2016-02-24 17:53:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 17:56:04 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 17:57:05 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9015dd1c96e0a403559983a94e41adb686aa3d8d
Cr-Commit-Position: refs/heads/master@{#34257}

Powered by Google App Engine
This is Rietveld 408576698