Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: src/crankshaft/hydrogen-instructions.h

Issue 1731303002: [crankshaft] Remove useless HCallFunction instruction. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/crankshaft/hydrogen-instructions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen-instructions.h
diff --git a/src/crankshaft/hydrogen-instructions.h b/src/crankshaft/hydrogen-instructions.h
index 22ed052ba39eccaf4500e8366d553765416b09e1..a9ab49d22ecb817fc0b8a72c542693069987995b 100644
--- a/src/crankshaft/hydrogen-instructions.h
+++ b/src/crankshaft/hydrogen-instructions.h
@@ -60,7 +60,6 @@ class LChunkBuilder;
V(Branch) \
V(CallWithDescriptor) \
V(CallJSFunction) \
- V(CallFunction) \
V(CallNewArray) \
V(CallRuntime) \
V(CapturedObject) \
@@ -2264,7 +2263,7 @@ class HCallWithDescriptor final : public HInstruction {
CallMode call_mode = NORMAL_CALL) {
HCallWithDescriptor* res = new (zone) HCallWithDescriptor(
target, argument_count, descriptor, operands, call_mode, zone);
- DCHECK(operands.length() == res->GetParameterCount());
+ DCHECK_EQ(operands.length(), res->GetParameterCount());
return res;
}
@@ -2390,49 +2389,6 @@ class HInvokeFunction final : public HBinaryCall {
};
-class HCallFunction final : public HBinaryCall {
- public:
- DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P3(HCallFunction, HValue*, int,
- ConvertReceiverMode);
-
- HValue* context() const { return first(); }
- HValue* function() const { return second(); }
-
- ConvertReceiverMode convert_mode() const {
- return ConvertReceiverModeField::decode(bit_field_);
- }
- FeedbackVectorSlot slot() const { return slot_; }
- Handle<TypeFeedbackVector> feedback_vector() const {
- return feedback_vector_;
- }
- bool HasVectorAndSlot() const { return !feedback_vector_.is_null(); }
- void SetVectorAndSlot(Handle<TypeFeedbackVector> vector,
- FeedbackVectorSlot slot) {
- feedback_vector_ = vector;
- slot_ = slot;
- }
-
- DECLARE_CONCRETE_INSTRUCTION(CallFunction)
-
- std::ostream& PrintDataTo(std::ostream& os) const override; // NOLINT
-
- int argument_delta() const override { return -argument_count(); }
-
- private:
- HCallFunction(HValue* context, HValue* function, int argument_count,
- ConvertReceiverMode convert_mode)
- : HBinaryCall(context, function, argument_count),
- bit_field_(ConvertReceiverModeField::encode(convert_mode)) {}
- Handle<TypeFeedbackVector> feedback_vector_;
- FeedbackVectorSlot slot_;
-
- class ConvertReceiverModeField : public BitField<ConvertReceiverMode, 0, 2> {
- };
-
- uint32_t bit_field_;
-};
-
-
class HCallNewArray final : public HBinaryCall {
public:
DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P4(HCallNewArray, HValue*, int,
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/crankshaft/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698