Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/crankshaft/x64/lithium-x64.cc

Issue 1731303002: [crankshaft] Remove useless HCallFunction instruction. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/x64/lithium-x64.h ('k') | src/crankshaft/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/x64/lithium-x64.h" 5 #include "src/crankshaft/x64/lithium-x64.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #if V8_TARGET_ARCH_X64 9 #if V8_TARGET_ARCH_X64
10 10
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 254
255 255
256 void LInnerAllocatedObject::PrintDataTo(StringStream* stream) { 256 void LInnerAllocatedObject::PrintDataTo(StringStream* stream) {
257 stream->Add(" = "); 257 stream->Add(" = ");
258 base_object()->PrintTo(stream); 258 base_object()->PrintTo(stream);
259 stream->Add(" + "); 259 stream->Add(" + ");
260 offset()->PrintTo(stream); 260 offset()->PrintTo(stream);
261 } 261 }
262 262
263 263
264 void LCallFunction::PrintDataTo(StringStream* stream) {
265 context()->PrintTo(stream);
266 stream->Add(" ");
267 function()->PrintTo(stream);
268 if (hydrogen()->HasVectorAndSlot()) {
269 stream->Add(" (type-feedback-vector ");
270 temp_vector()->PrintTo(stream);
271 stream->Add(" ");
272 temp_slot()->PrintTo(stream);
273 stream->Add(")");
274 }
275 }
276
277
278 void LCallJSFunction::PrintDataTo(StringStream* stream) { 264 void LCallJSFunction::PrintDataTo(StringStream* stream) {
279 stream->Add("= "); 265 stream->Add("= ");
280 function()->PrintTo(stream); 266 function()->PrintTo(stream);
281 stream->Add("#%d / ", arity()); 267 stream->Add("#%d / ", arity());
282 } 268 }
283 269
284 270
285 void LCallWithDescriptor::PrintDataTo(StringStream* stream) { 271 void LCallWithDescriptor::PrintDataTo(StringStream* stream) {
286 for (int i = 0; i < InputCount(); i++) { 272 for (int i = 0; i < InputCount(); i++) {
287 InputAt(i)->PrintTo(stream); 273 InputAt(i)->PrintTo(stream);
(...skipping 939 matching lines...) Expand 10 before | Expand all | Expand 10 after
1227 1213
1228 1214
1229 LInstruction* LChunkBuilder::DoCallNewArray(HCallNewArray* instr) { 1215 LInstruction* LChunkBuilder::DoCallNewArray(HCallNewArray* instr) {
1230 LOperand* context = UseFixed(instr->context(), rsi); 1216 LOperand* context = UseFixed(instr->context(), rsi);
1231 LOperand* constructor = UseFixed(instr->constructor(), rdi); 1217 LOperand* constructor = UseFixed(instr->constructor(), rdi);
1232 LCallNewArray* result = new(zone()) LCallNewArray(context, constructor); 1218 LCallNewArray* result = new(zone()) LCallNewArray(context, constructor);
1233 return MarkAsCall(DefineFixed(result, rax), instr); 1219 return MarkAsCall(DefineFixed(result, rax), instr);
1234 } 1220 }
1235 1221
1236 1222
1237 LInstruction* LChunkBuilder::DoCallFunction(HCallFunction* instr) {
1238 LOperand* context = UseFixed(instr->context(), rsi);
1239 LOperand* function = UseFixed(instr->function(), rdi);
1240 LOperand* slot = NULL;
1241 LOperand* vector = NULL;
1242 if (instr->HasVectorAndSlot()) {
1243 slot = FixedTemp(rdx);
1244 vector = FixedTemp(rbx);
1245 }
1246 LCallFunction* call =
1247 new (zone()) LCallFunction(context, function, slot, vector);
1248 return MarkAsCall(DefineFixed(call, rax), instr);
1249 }
1250
1251
1252 LInstruction* LChunkBuilder::DoCallRuntime(HCallRuntime* instr) { 1223 LInstruction* LChunkBuilder::DoCallRuntime(HCallRuntime* instr) {
1253 LOperand* context = UseFixed(instr->context(), rsi); 1224 LOperand* context = UseFixed(instr->context(), rsi);
1254 LCallRuntime* result = new(zone()) LCallRuntime(context); 1225 LCallRuntime* result = new(zone()) LCallRuntime(context);
1255 return MarkAsCall(DefineFixed(result, rax), instr); 1226 return MarkAsCall(DefineFixed(result, rax), instr);
1256 } 1227 }
1257 1228
1258 1229
1259 LInstruction* LChunkBuilder::DoRor(HRor* instr) { 1230 LInstruction* LChunkBuilder::DoRor(HRor* instr) {
1260 return DoShift(Token::ROR, instr); 1231 return DoShift(Token::ROR, instr);
1261 } 1232 }
(...skipping 1392 matching lines...) Expand 10 before | Expand all | Expand 10 after
2654 LInstruction* LChunkBuilder::DoStoreFrameContext(HStoreFrameContext* instr) { 2625 LInstruction* LChunkBuilder::DoStoreFrameContext(HStoreFrameContext* instr) {
2655 LOperand* context = UseRegisterAtStart(instr->context()); 2626 LOperand* context = UseRegisterAtStart(instr->context());
2656 return new(zone()) LStoreFrameContext(context); 2627 return new(zone()) LStoreFrameContext(context);
2657 } 2628 }
2658 2629
2659 2630
2660 } // namespace internal 2631 } // namespace internal
2661 } // namespace v8 2632 } // namespace v8
2662 2633
2663 #endif // V8_TARGET_ARCH_X64 2634 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/crankshaft/x64/lithium-x64.h ('k') | src/crankshaft/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698