Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: src/crankshaft/mips/lithium-mips.cc

Issue 1731303002: [crankshaft] Remove useless HCallFunction instruction. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/mips/lithium-mips.h ('k') | src/crankshaft/mips64/lithium-codegen-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/mips/lithium-mips.h" 5 #include "src/crankshaft/mips/lithium-mips.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #if V8_TARGET_ARCH_MIPS 9 #if V8_TARGET_ARCH_MIPS
10 10
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 248
249 249
250 void LInnerAllocatedObject::PrintDataTo(StringStream* stream) { 250 void LInnerAllocatedObject::PrintDataTo(StringStream* stream) {
251 stream->Add(" = "); 251 stream->Add(" = ");
252 base_object()->PrintTo(stream); 252 base_object()->PrintTo(stream);
253 stream->Add(" + "); 253 stream->Add(" + ");
254 offset()->PrintTo(stream); 254 offset()->PrintTo(stream);
255 } 255 }
256 256
257 257
258 void LCallFunction::PrintDataTo(StringStream* stream) {
259 context()->PrintTo(stream);
260 stream->Add(" ");
261 function()->PrintTo(stream);
262 if (hydrogen()->HasVectorAndSlot()) {
263 stream->Add(" (type-feedback-vector ");
264 temp_vector()->PrintTo(stream);
265 stream->Add(" ");
266 temp_slot()->PrintTo(stream);
267 stream->Add(")");
268 }
269 }
270
271
272 void LCallJSFunction::PrintDataTo(StringStream* stream) { 258 void LCallJSFunction::PrintDataTo(StringStream* stream) {
273 stream->Add("= "); 259 stream->Add("= ");
274 function()->PrintTo(stream); 260 function()->PrintTo(stream);
275 stream->Add("#%d / ", arity()); 261 stream->Add("#%d / ", arity());
276 } 262 }
277 263
278 264
279 void LCallWithDescriptor::PrintDataTo(StringStream* stream) { 265 void LCallWithDescriptor::PrintDataTo(StringStream* stream) {
280 for (int i = 0; i < InputCount(); i++) { 266 for (int i = 0; i < InputCount(); i++) {
281 InputAt(i)->PrintTo(stream); 267 InputAt(i)->PrintTo(stream);
(...skipping 935 matching lines...) Expand 10 before | Expand all | Expand 10 after
1217 1203
1218 1204
1219 LInstruction* LChunkBuilder::DoCallNewArray(HCallNewArray* instr) { 1205 LInstruction* LChunkBuilder::DoCallNewArray(HCallNewArray* instr) {
1220 LOperand* context = UseFixed(instr->context(), cp); 1206 LOperand* context = UseFixed(instr->context(), cp);
1221 LOperand* constructor = UseFixed(instr->constructor(), a1); 1207 LOperand* constructor = UseFixed(instr->constructor(), a1);
1222 LCallNewArray* result = new(zone()) LCallNewArray(context, constructor); 1208 LCallNewArray* result = new(zone()) LCallNewArray(context, constructor);
1223 return MarkAsCall(DefineFixed(result, v0), instr); 1209 return MarkAsCall(DefineFixed(result, v0), instr);
1224 } 1210 }
1225 1211
1226 1212
1227 LInstruction* LChunkBuilder::DoCallFunction(HCallFunction* instr) {
1228 LOperand* context = UseFixed(instr->context(), cp);
1229 LOperand* function = UseFixed(instr->function(), a1);
1230 LOperand* slot = NULL;
1231 LOperand* vector = NULL;
1232 if (instr->HasVectorAndSlot()) {
1233 slot = FixedTemp(a3);
1234 vector = FixedTemp(a2);
1235 }
1236
1237 LCallFunction* call =
1238 new (zone()) LCallFunction(context, function, slot, vector);
1239 return MarkAsCall(DefineFixed(call, v0), instr);
1240 }
1241
1242
1243 LInstruction* LChunkBuilder::DoCallRuntime(HCallRuntime* instr) { 1213 LInstruction* LChunkBuilder::DoCallRuntime(HCallRuntime* instr) {
1244 LOperand* context = UseFixed(instr->context(), cp); 1214 LOperand* context = UseFixed(instr->context(), cp);
1245 return MarkAsCall(DefineFixed(new(zone()) LCallRuntime(context), v0), instr); 1215 return MarkAsCall(DefineFixed(new(zone()) LCallRuntime(context), v0), instr);
1246 } 1216 }
1247 1217
1248 1218
1249 LInstruction* LChunkBuilder::DoRor(HRor* instr) { 1219 LInstruction* LChunkBuilder::DoRor(HRor* instr) {
1250 return DoShift(Token::ROR, instr); 1220 return DoShift(Token::ROR, instr);
1251 } 1221 }
1252 1222
(...skipping 1294 matching lines...) Expand 10 before | Expand all | Expand 10 after
2547 2517
2548 LInstruction* LChunkBuilder::DoStoreFrameContext(HStoreFrameContext* instr) { 2518 LInstruction* LChunkBuilder::DoStoreFrameContext(HStoreFrameContext* instr) {
2549 LOperand* context = UseRegisterAtStart(instr->context()); 2519 LOperand* context = UseRegisterAtStart(instr->context());
2550 return new(zone()) LStoreFrameContext(context); 2520 return new(zone()) LStoreFrameContext(context);
2551 } 2521 }
2552 2522
2553 } // namespace internal 2523 } // namespace internal
2554 } // namespace v8 2524 } // namespace v8
2555 2525
2556 #endif // V8_TARGET_ARCH_MIPS 2526 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/crankshaft/mips/lithium-mips.h ('k') | src/crankshaft/mips64/lithium-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698