Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: src/crankshaft/ia32/lithium-ia32.cc

Issue 1731303002: [crankshaft] Remove useless HCallFunction instruction. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/ia32/lithium-ia32.h ('k') | src/crankshaft/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/ia32/lithium-ia32.h" 5 #include "src/crankshaft/ia32/lithium-ia32.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #if V8_TARGET_ARCH_IA32 9 #if V8_TARGET_ARCH_IA32
10 10
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 260
261 261
262 void LInnerAllocatedObject::PrintDataTo(StringStream* stream) { 262 void LInnerAllocatedObject::PrintDataTo(StringStream* stream) {
263 stream->Add(" = "); 263 stream->Add(" = ");
264 base_object()->PrintTo(stream); 264 base_object()->PrintTo(stream);
265 stream->Add(" + "); 265 stream->Add(" + ");
266 offset()->PrintTo(stream); 266 offset()->PrintTo(stream);
267 } 267 }
268 268
269 269
270 void LCallFunction::PrintDataTo(StringStream* stream) {
271 context()->PrintTo(stream);
272 stream->Add(" ");
273 function()->PrintTo(stream);
274 if (hydrogen()->HasVectorAndSlot()) {
275 stream->Add(" (type-feedback-vector ");
276 temp_vector()->PrintTo(stream);
277 stream->Add(" ");
278 temp_slot()->PrintTo(stream);
279 stream->Add(")");
280 }
281 }
282
283
284 void LCallJSFunction::PrintDataTo(StringStream* stream) { 270 void LCallJSFunction::PrintDataTo(StringStream* stream) {
285 stream->Add("= "); 271 stream->Add("= ");
286 function()->PrintTo(stream); 272 function()->PrintTo(stream);
287 stream->Add("#%d / ", arity()); 273 stream->Add("#%d / ", arity());
288 } 274 }
289 275
290 276
291 void LCallWithDescriptor::PrintDataTo(StringStream* stream) { 277 void LCallWithDescriptor::PrintDataTo(StringStream* stream) {
292 for (int i = 0; i < InputCount(); i++) { 278 for (int i = 0; i < InputCount(); i++) {
293 InputAt(i)->PrintTo(stream); 279 InputAt(i)->PrintTo(stream);
(...skipping 952 matching lines...) Expand 10 before | Expand all | Expand 10 after
1246 1232
1247 1233
1248 LInstruction* LChunkBuilder::DoCallNewArray(HCallNewArray* instr) { 1234 LInstruction* LChunkBuilder::DoCallNewArray(HCallNewArray* instr) {
1249 LOperand* context = UseFixed(instr->context(), esi); 1235 LOperand* context = UseFixed(instr->context(), esi);
1250 LOperand* constructor = UseFixed(instr->constructor(), edi); 1236 LOperand* constructor = UseFixed(instr->constructor(), edi);
1251 LCallNewArray* result = new(zone()) LCallNewArray(context, constructor); 1237 LCallNewArray* result = new(zone()) LCallNewArray(context, constructor);
1252 return MarkAsCall(DefineFixed(result, eax), instr); 1238 return MarkAsCall(DefineFixed(result, eax), instr);
1253 } 1239 }
1254 1240
1255 1241
1256 LInstruction* LChunkBuilder::DoCallFunction(HCallFunction* instr) {
1257 LOperand* context = UseFixed(instr->context(), esi);
1258 LOperand* function = UseFixed(instr->function(), edi);
1259 LOperand* slot = NULL;
1260 LOperand* vector = NULL;
1261 if (instr->HasVectorAndSlot()) {
1262 slot = FixedTemp(edx);
1263 vector = FixedTemp(ebx);
1264 }
1265
1266 LCallFunction* call =
1267 new (zone()) LCallFunction(context, function, slot, vector);
1268 return MarkAsCall(DefineFixed(call, eax), instr);
1269 }
1270
1271
1272 LInstruction* LChunkBuilder::DoCallRuntime(HCallRuntime* instr) { 1242 LInstruction* LChunkBuilder::DoCallRuntime(HCallRuntime* instr) {
1273 LOperand* context = UseFixed(instr->context(), esi); 1243 LOperand* context = UseFixed(instr->context(), esi);
1274 return MarkAsCall(DefineFixed(new(zone()) LCallRuntime(context), eax), instr); 1244 return MarkAsCall(DefineFixed(new(zone()) LCallRuntime(context), eax), instr);
1275 } 1245 }
1276 1246
1277 1247
1278 LInstruction* LChunkBuilder::DoRor(HRor* instr) { 1248 LInstruction* LChunkBuilder::DoRor(HRor* instr) {
1279 return DoShift(Token::ROR, instr); 1249 return DoShift(Token::ROR, instr);
1280 } 1250 }
1281 1251
(...skipping 1382 matching lines...) Expand 10 before | Expand all | Expand 10 after
2664 LInstruction* LChunkBuilder::DoStoreFrameContext(HStoreFrameContext* instr) { 2634 LInstruction* LChunkBuilder::DoStoreFrameContext(HStoreFrameContext* instr) {
2665 LOperand* context = UseRegisterAtStart(instr->context()); 2635 LOperand* context = UseRegisterAtStart(instr->context());
2666 return new(zone()) LStoreFrameContext(context); 2636 return new(zone()) LStoreFrameContext(context);
2667 } 2637 }
2668 2638
2669 2639
2670 } // namespace internal 2640 } // namespace internal
2671 } // namespace v8 2641 } // namespace v8
2672 2642
2673 #endif // V8_TARGET_ARCH_IA32 2643 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/crankshaft/ia32/lithium-ia32.h ('k') | src/crankshaft/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698