Remove PasswordStore::AuthorizationPromptPolicy

Remove PasswordStore::AuthorizationPromptPolicy

The only value of this enum used in production code since we dropped the MacOS
Keychain support was "DISALLOW_PROMPT". This CL removes the whole enum.

The connection to bug 582087 is that this CL simplifies the signature of GetLogins, which is related to fixing that bug.

This CL also fixes two missing braces pointed out by git cl lint.

R=vasilii@chromium.org
BUG=582087, 466638
Committed: https://crrev.com/bf29a1600f626b2c334ea6f4e346fda89f1cd5a2
Cr-Commit-Position: refs/heads/master@{#377853}

[vabr (Chromium), 2016-02-25 15:00:48]

Description was changed from

==========
Remove PasswordStore::AuthorizationPromptPolicy

The only value of this enum used in production code since we dropped the MacOS
Keychain supporti was "DISALLOW_PROMPT". This CL removes the whole enum.

R=vasilii@chromium.org
BUG=582087,466638
==========

to

==========
Remove PasswordStore::AuthorizationPromptPolicy

The only value of this enum used in production code since we dropped the MacOS
Keychain supporti was "DISALLOW_PROMPT". This CL removes the whole enum.

The connection to bug 582087 is that this CL simplifies the signature of
GetLogins, which is related to fixing that bug.

This CL also fixes two missing braces pointed out by git cl lint.

R=vasilii@chromium.org
BUG=582087,466638
==========

[vabr (Chromium), 2016-02-25 15:19:40]

vabr@chromium.org changed reviewers:
+ pavely@chromium.org

[vabr (Chromium), 2016-02-25 15:19:41]

Hi Vasilii,
Please review the whole CL.

Hi Pavel,
please review chrome/browser/sync/test/integration/passwords_helper.cc.

Thanks!
Vaclav

[vasilii, 2016-02-25 16:06:17]

lgtm

[vabr (Chromium), 2016-02-25 16:35:15]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-02-25 16:37:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1730313004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1730313004/1

[commit-bot: I haz the power, 2016-02-25 16:55:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 16:55:04]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[vabr (Chromium), 2016-02-25 19:31:55]

Description was changed from

==========
Remove PasswordStore::AuthorizationPromptPolicy

The only value of this enum used in production code since we dropped the MacOS
Keychain supporti was "DISALLOW_PROMPT". This CL removes the whole enum.

The connection to bug 582087 is that this CL simplifies the signature of
GetLogins, which is related to fixing that bug.

This CL also fixes two missing braces pointed out by git cl lint.

R=vasilii@chromium.org
BUG=582087,466638
==========

to

==========
Remove PasswordStore::AuthorizationPromptPolicy

The only value of this enum used in production code since we dropped the MacOS
Keychain support was "DISALLOW_PROMPT". This CL removes the whole enum.

The connection to bug 582087 is that this CL simplifies the signature of
GetLogins, which is related to fixing that bug.

This CL also fixes two missing braces pointed out by git cl lint.

R=vasilii@chromium.org
BUG=582087,466638
==========

[pavely, 2016-02-25 20:20:31]

chrome/browser/sync: lgtm

[vabr (Chromium), 2016-02-26 08:21:47]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-02-26 08:22:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1730313004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1730313004/1

[commit-bot: I haz the power, 2016-02-26 08:29:48]

Description was changed from

==========
Remove PasswordStore::AuthorizationPromptPolicy

The only value of this enum used in production code since we dropped the MacOS
Keychain support was "DISALLOW_PROMPT". This CL removes the whole enum.

The connection to bug 582087 is that this CL simplifies the signature of
GetLogins, which is related to fixing that bug.

This CL also fixes two missing braces pointed out by git cl lint.

R=vasilii@chromium.org
BUG=582087,466638
==========

to

==========
Remove PasswordStore::AuthorizationPromptPolicy

The only value of this enum used in production code since we dropped the MacOS
Keychain support was "DISALLOW_PROMPT". This CL removes the whole enum.

The connection to bug 582087 is that this CL simplifies the signature of
GetLogins, which is related to fixing that bug.

This CL also fixes two missing braces pointed out by git cl lint.

R=vasilii@chromium.org
BUG=582087,466638
==========

[commit-bot: I haz the power, 2016-02-26 08:29:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-26 08:30:54]

Description was changed from

==========
Remove PasswordStore::AuthorizationPromptPolicy

The only value of this enum used in production code since we dropped the MacOS
Keychain support was "DISALLOW_PROMPT". This CL removes the whole enum.

The connection to bug 582087 is that this CL simplifies the signature of
GetLogins, which is related to fixing that bug.

This CL also fixes two missing braces pointed out by git cl lint.

R=vasilii@chromium.org
BUG=582087,466638
==========

to

==========
Remove PasswordStore::AuthorizationPromptPolicy

The only value of this enum used in production code since we dropped the MacOS
Keychain support was "DISALLOW_PROMPT". This CL removes the whole enum.

The connection to bug 582087 is that this CL simplifies the signature of
GetLogins, which is related to fixing that bug.

This CL also fixes two missing braces pointed out by git cl lint.

R=vasilii@chromium.org
BUG=582087,466638

Committed: https://crrev.com/bf29a1600f626b2c334ea6f4e346fda89f1cd5a2
Cr-Commit-Position: refs/heads/master@{#377853}
==========

[commit-bot: I haz the power, 2016-02-26 08:30:55]

Patchset 1 (id:??) landed as
https://crrev.com/bf29a1600f626b2c334ea6f4e346fda89f1cd5a2
Cr-Commit-Position: refs/heads/master@{#377853}