Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: components/password_manager/core/browser/password_store.h

Issue 1730313004: Remove PasswordStore::AuthorizationPromptPolicy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store.h
diff --git a/components/password_manager/core/browser/password_store.h b/components/password_manager/core/browser/password_store.h
index ccc2353266a64eb8b0e1e041d2dcb64ca4739eb5..02df82bc04671ec11bb4bec43d07dfc9f12d3c5d 100644
--- a/components/password_manager/core/browser/password_store.h
+++ b/components/password_manager/core/browser/password_store.h
@@ -55,10 +55,6 @@ struct InteractionsStats;
class PasswordStore : protected PasswordStoreSync,
public RefcountedKeyedService {
public:
- // Whether or not it's acceptable for Chrome to request access to locked
- // passwords, which requires prompting the user for permission.
- enum AuthorizationPromptPolicy { ALLOW_PROMPT, DISALLOW_PROMPT };
-
// An interface used to notify clients (observers) of this object that data in
// the password store has changed. Register the observer via
// PasswordStore::AddObserver.
@@ -148,16 +144,10 @@ class PasswordStore : protected PasswordStoreSync,
// Searches for a matching PasswordForm, and notifies |consumer| on
// completion. The request will be cancelled if the consumer is destroyed.
- // |prompt_policy| indicates whether it's permissible to prompt the user to
- // authorize access to locked passwords. This argument is only used on
- // platforms that support prompting the user for access (such as Mac OS).
- // NOTE: This means that this method can return different results depending
- // on the value of |prompt_policy|.
// TODO(engedy): Currently, this will not return federated logins saved from
// Android applications that are affiliated with the realm of |form|. Need to
// decide if this is the desired behavior. See: https://crbug.com/539844.
virtual void GetLogins(const autofill::PasswordForm& form,
- AuthorizationPromptPolicy prompt_policy,
PasswordStoreConsumer* consumer);
// Gets the complete list of PasswordForms that are not blacklist entries--and
@@ -272,7 +262,6 @@ class PasswordStore : protected PasswordStoreSync,
// to be virtual only because asynchronous behavior in PasswordStoreWin.
// TODO(engedy): Make this non-virtual once https://crbug.com/78830 is fixed.
virtual void GetLoginsImpl(const autofill::PasswordForm& form,
- AuthorizationPromptPolicy prompt_policy,
scoped_ptr<GetLoginsRequest> request);
// Synchronous implementation provided by subclasses to add the given login.
@@ -292,8 +281,7 @@ class PasswordStore : protected PasswordStoreSync,
// Finds and returns all PasswordForms with the same signon_realm as |form|,
// or with a signon_realm that is a PSL-match to that of |form|.
virtual ScopedVector<autofill::PasswordForm> FillMatchingLogins(
- const autofill::PasswordForm& form,
- AuthorizationPromptPolicy prompt_policy) = 0;
+ const autofill::PasswordForm& form) = 0;
// Synchronous implementation for manipulating with statistics.
virtual void AddSiteStatsImpl(const InteractionsStats& stats) = 0;
@@ -386,14 +374,12 @@ class PasswordStore : protected PasswordStoreSync,
// and takes care of notifying the consumer with the results when done.
void GetLoginsWithAffiliationsImpl(
const autofill::PasswordForm& form,
- AuthorizationPromptPolicy prompt_policy,
scoped_ptr<GetLoginsRequest> request,
const std::vector<std::string>& additional_android_realms);
// Schedules GetLoginsWithAffiliationsImpl() to be run on the DB thread.
void ScheduleGetLoginsWithAffiliations(
const autofill::PasswordForm& form,
- AuthorizationPromptPolicy prompt_policy,
scoped_ptr<GetLoginsRequest> request,
const std::vector<std::string>& additional_android_realms);

Powered by Google App Engine
This is Rietveld 408576698