Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: components/password_manager/core/browser/password_manager_client.cc

Issue 1730313004: Remove PasswordStore::AuthorizationPromptPolicy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "components/password_manager/core/browser/password_manager_client.h" 6 #include "components/password_manager/core/browser/password_manager_client.h"
7 7
8 namespace password_manager { 8 namespace password_manager {
9 9
10 bool PasswordManagerClient::IsAutomaticPasswordSavingEnabled() const { 10 bool PasswordManagerClient::IsAutomaticPasswordSavingEnabled() const {
(...skipping 18 matching lines...) Expand all
29 const GURL& origin) const {} 29 const GURL& origin) const {}
30 30
31 PasswordSyncState PasswordManagerClient::GetPasswordSyncState() const { 31 PasswordSyncState PasswordManagerClient::GetPasswordSyncState() const {
32 return NOT_SYNCING_PASSWORDS; 32 return NOT_SYNCING_PASSWORDS;
33 } 33 }
34 34
35 bool PasswordManagerClient::WasLastNavigationHTTPError() const { 35 bool PasswordManagerClient::WasLastNavigationHTTPError() const {
36 return false; 36 return false;
37 } 37 }
38 38
39 PasswordStore::AuthorizationPromptPolicy
40 PasswordManagerClient::GetAuthorizationPromptPolicy(
41 const autofill::PasswordForm& form) {
42 // Password Autofill is supposed to be a convenience. If it creates a
43 // blocking dialog, it is no longer convenient. We should only prompt the
44 // user after a full username has been typed in. Until that behavior is
45 // implemented, never prompt the user for keychain access.
46 // Effectively, this means that passwords stored by Chrome still work,
47 // since Chrome can access those without a prompt, but passwords stored by
48 // Safari, Firefox, or Chrome Canary will not work. Note that the latest
49 // build of Safari and Firefox don't create keychain items with the
50 // relevant tags anyways (7/11/2014).
51 // http://crbug.com/178358
52 return PasswordStore::DISALLOW_PROMPT;
53 }
54
55 bool PasswordManagerClient::DidLastPageLoadEncounterSSLErrors() const { 39 bool PasswordManagerClient::DidLastPageLoadEncounterSSLErrors() const {
56 return false; 40 return false;
57 } 41 }
58 42
59 bool PasswordManagerClient::IsOffTheRecord() const { 43 bool PasswordManagerClient::IsOffTheRecord() const {
60 return false; 44 return false;
61 } 45 }
62 46
63 const PasswordManager* PasswordManagerClient::GetPasswordManager() const { 47 const PasswordManager* PasswordManagerClient::GetPasswordManager() const {
64 return nullptr; 48 return nullptr;
(...skipping 15 matching lines...) Expand all
80 64
81 bool PasswordManagerClient::IsUpdatePasswordUIEnabled() const { 65 bool PasswordManagerClient::IsUpdatePasswordUIEnabled() const {
82 return false; 66 return false;
83 } 67 }
84 68
85 const LogManager* PasswordManagerClient::GetLogManager() const { 69 const LogManager* PasswordManagerClient::GetLogManager() const {
86 return nullptr; 70 return nullptr;
87 } 71 }
88 72
89 } // namespace password_manager 73 } // namespace password_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698