Remove PasswordStore::AuthorizationPromptPolicy

components/password_manager/core/browser/password_store.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_STORE_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_STORE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 37 matching lines @@
 // Implementations, however, should carry out most tasks asynchronously on a
 // background thread: the base class provides functionality to facilitate this.
 // I/O heavy initialization should also be performed asynchronously in this
 // manner. If this deferred initialization fails, all subsequent method calls
 // should fail without side effects, return no data, and send no notifications.
 // PasswordStoreSync is a hidden base class because only PasswordSyncableService
 // needs to access these methods.
 class PasswordStore : protected PasswordStoreSync,
                       public RefcountedKeyedService {
  public:
-  // Whether or not it's acceptable for Chrome to request access to locked
-  // passwords, which requires prompting the user for permission.
-  enum AuthorizationPromptPolicy { ALLOW_PROMPT, DISALLOW_PROMPT };
-
   // An interface used to notify clients (observers) of this object that data in
   // the password store has changed. Register the observer via
   // PasswordStore::AddObserver.
   class Observer {
    public:
     // Notifies the observer that password data changed. Will be called from
     // the UI thread.
     virtual void OnLoginsChanged(const PasswordStoreChangeList& changes) = 0;
 
    protected:
@@ skipping 69 matching lines @@
   void RemoveStatisticsCreatedBetween(base::Time delete_begin,
                                       base::Time delete_end,
                                       const base::Closure& completion);
 
   // Removes cached affiliation data that is no longer needed; provided that
   // affiliation-based matching is enabled.
   void TrimAffiliationCache();
 
   // Searches for a matching PasswordForm, and notifies |consumer| on
   // completion. The request will be cancelled if the consumer is destroyed.
-  // |prompt_policy| indicates whether it's permissible to prompt the user to
-  // authorize access to locked passwords. This argument is only used on
-  // platforms that support prompting the user for access (such as Mac OS).
-  // NOTE: This means that this method can return different results depending
-  // on the value of |prompt_policy|.
   // TODO(engedy): Currently, this will not return federated logins saved from
   // Android applications that are affiliated with the realm of |form|. Need to
   // decide if this is the desired behavior. See: https://crbug.com/539844.
   virtual void GetLogins(const autofill::PasswordForm& form,
-                         AuthorizationPromptPolicy prompt_policy,
                          PasswordStoreConsumer* consumer);
 
   // Gets the complete list of PasswordForms that are not blacklist entries--and
   // are thus auto-fillable. |consumer| will be notified on completion.
   // The request will be cancelled if the consumer is destroyed.
   virtual void GetAutofillableLogins(PasswordStoreConsumer* consumer);
 
   // Gets the complete list of PasswordForms that are blacklist entries,
   // and notify |consumer| on completion. The request will be cancelled if the
   // consumer is destroyed.
@@ skipping 94 matching lines @@
   virtual bool RemoveStatisticsCreatedBetweenImpl(base::Time delete_begin,
                                                   base::Time delete_end) = 0;
 
   // Finds all PasswordForms with a signon_realm that is equal to, or is a
   // PSL-match to that of |form|, and takes care of notifying the consumer with
   // the results when done.
   // Note: subclasses should implement FillMatchingLogins() instead. This needs
   // to be virtual only because asynchronous behavior in PasswordStoreWin.
   // TODO(engedy): Make this non-virtual once https://crbug.com/78830 is fixed.
   virtual void GetLoginsImpl(const autofill::PasswordForm& form,
-                             AuthorizationPromptPolicy prompt_policy,
                              scoped_ptr<GetLoginsRequest> request);
 
   // Synchronous implementation provided by subclasses to add the given login.
   virtual PasswordStoreChangeList AddLoginImpl(
       const autofill::PasswordForm& form) = 0;
 
   // Synchronous implementation provided by subclasses to update the given
   // login.
   virtual PasswordStoreChangeList UpdateLoginImpl(
       const autofill::PasswordForm& form) = 0;
 
   // Synchronous implementation provided by subclasses to remove the given
   // login.
   virtual PasswordStoreChangeList RemoveLoginImpl(
       const autofill::PasswordForm& form) = 0;
 
   // Finds and returns all PasswordForms with the same signon_realm as |form|,
   // or with a signon_realm that is a PSL-match to that of |form|.
   virtual ScopedVector<autofill::PasswordForm> FillMatchingLogins(
-      const autofill::PasswordForm& form,
-      AuthorizationPromptPolicy prompt_policy) = 0;
+      const autofill::PasswordForm& form) = 0;
 
   // Synchronous implementation for manipulating with statistics.
   virtual void AddSiteStatsImpl(const InteractionsStats& stats) = 0;
   virtual void RemoveSiteStatsImpl(const GURL& origin_domain) = 0;
   virtual std::vector<scoped_ptr<InteractionsStats>> GetSiteStatsImpl(
       const GURL& origin_domain) = 0;
 
   // Log UMA stats for number of bulk deletions.
   void LogStatsForBulkDeletion(int num_deletions);
 
@@ skipping 72 matching lines @@
 
   // Extended version of GetLoginsImpl that also returns credentials stored for
   // the specified affiliated Android applications. That is, it finds all
   // PasswordForms with a signon_realm that is either:
   //  * equal to that of |form|,
   //  * is a PSL-match to the realm of |form|,
   //  * is one of those in |additional_android_realms|,
   // and takes care of notifying the consumer with the results when done.
   void GetLoginsWithAffiliationsImpl(
       const autofill::PasswordForm& form,
-      AuthorizationPromptPolicy prompt_policy,
       scoped_ptr<GetLoginsRequest> request,
       const std::vector<std::string>& additional_android_realms);
 
   // Schedules GetLoginsWithAffiliationsImpl() to be run on the DB thread.
   void ScheduleGetLoginsWithAffiliations(
       const autofill::PasswordForm& form,
-      AuthorizationPromptPolicy prompt_policy,
       scoped_ptr<GetLoginsRequest> request,
       const std::vector<std::string>& additional_android_realms);
 
   // Retrieves the currently stored form, if any, with the same primary key as
   // |form|, that is, with the same signon_realm, origin, username_element,
   // username_value and password_element attributes. To be called on the
   // background thread.
   scoped_ptr<autofill::PasswordForm> GetLoginImpl(
       const autofill::PasswordForm& primary_key);
 
@@ skipping 37 matching lines @@
   bool is_propagating_password_changes_to_web_credentials_enabled_;
 
   bool shutdown_called_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordStore);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_STORE_H_