Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: components/password_manager/core/browser/password_manager_client.cc

Issue 1730313004: Remove PasswordStore::AuthorizationPromptPolicy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_client.cc
diff --git a/components/password_manager/core/browser/password_manager_client.cc b/components/password_manager/core/browser/password_manager_client.cc
index c7b11981b7c495c6fbac392b51e9fa302e2d6b6c..78ed5caa699b2cf33f8ffcb89a48db9834cee82d 100644
--- a/components/password_manager/core/browser/password_manager_client.cc
+++ b/components/password_manager/core/browser/password_manager_client.cc
@@ -36,22 +36,6 @@ bool PasswordManagerClient::WasLastNavigationHTTPError() const {
return false;
}
-PasswordStore::AuthorizationPromptPolicy
-PasswordManagerClient::GetAuthorizationPromptPolicy(
- const autofill::PasswordForm& form) {
- // Password Autofill is supposed to be a convenience. If it creates a
- // blocking dialog, it is no longer convenient. We should only prompt the
- // user after a full username has been typed in. Until that behavior is
- // implemented, never prompt the user for keychain access.
- // Effectively, this means that passwords stored by Chrome still work,
- // since Chrome can access those without a prompt, but passwords stored by
- // Safari, Firefox, or Chrome Canary will not work. Note that the latest
- // build of Safari and Firefox don't create keychain items with the
- // relevant tags anyways (7/11/2014).
- // http://crbug.com/178358
- return PasswordStore::DISALLOW_PROMPT;
-}
-
bool PasswordManagerClient::DidLastPageLoadEncounterSSLErrors() const {
return false;
}

Powered by Google App Engine
This is Rietveld 408576698