Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1728873002: DevTools: simplify JSONValues API, prepare to the OwnPtr migration. (Closed)

Created:
4 years, 10 months ago by pfeldman
Modified:
4 years, 10 months ago
Reviewers:
dgozman, dcheng
CC:
apavlov+blink_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, danakj+watch_chromium.org, devtools-reviews_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pdr+graphicswatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, vmpstr+blinkwatch_chromium.org, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: simplify JSONValues API, prepare to the OwnPtr migration. BUG=580337 Committed: https://crrev.com/ffa7f6f9c55e36077e8431714d2f3a52646bbeae Cr-Commit-Position: refs/heads/master@{#377536}

Patch Set 1 #

Patch Set 2 : tests fixed #

Patch Set 3 : rebaselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -255 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/JSONParserTest.cpp View 10 chunks +24 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/JSONValues.h View 8 chunks +35 lines, -87 lines 0 comments Download
M third_party/WebKit/Source/platform/JSONValues.cpp View 10 chunks +33 lines, -90 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 2 13 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template View 1 2 5 chunks +12 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 1 2 12 chunks +13 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (15 generated)
pfeldman
4 years, 10 months ago (2016-02-23 23:40:07 UTC) #2
dgozman
lgtm
4 years, 10 months ago (2016-02-24 01:37:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728873002/1
4 years, 10 months ago (2016-02-24 01:40:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/184726)
4 years, 10 months ago (2016-02-24 04:07:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/184726)
4 years, 10 months ago (2016-02-24 04:08:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728873002/20001
4 years, 10 months ago (2016-02-24 20:41:25 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-24 22:21:00 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/43c8de64e250e814ea15c4240d5d4273a8272535 Cr-Commit-Position: refs/heads/master@{#377409}
4 years, 10 months ago (2016-02-24 22:22:17 UTC) #14
dcheng
Unfortunately, it looks like this collided with https://codereview.chromium.org/1730653002 so I'm going to revert to fix ...
4 years, 10 months ago (2016-02-24 22:35:28 UTC) #16
dcheng
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1734693003/ by dcheng@chromium.org. ...
4 years, 10 months ago (2016-02-24 22:35:46 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728873002/40001
4 years, 10 months ago (2016-02-25 06:00:16 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/179347)
4 years, 10 months ago (2016-02-25 07:30:27 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1728873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1728873002/40001
4 years, 10 months ago (2016-02-25 07:47:11 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-25 08:37:31 UTC) #28
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 08:38:33 UTC) #30
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ffa7f6f9c55e36077e8431714d2f3a52646bbeae
Cr-Commit-Position: refs/heads/master@{#377536}

Powered by Google App Engine
This is Rietveld 408576698