third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp - Issue 1728873002: DevTools: simplify JSONValues API, prepare to the OwnPtr migration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp

Issue 1728873002: DevTools: simplify JSONValues API, prepare to the OwnPtr migration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselines Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp b/third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp

index d15b0cf9dc00f4575d41b68b698de648c48e9419..35542df790e3809fc77a68827a84b977c68bfc2b 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp

@@ -20,7 +20,7 @@ PassRefPtr<JSONObject> RemoteObjectIdBase::parseInjectedScriptId(const String& o

if (!parsedValue || parsedValue->type() != JSONValue::TypeObject)

return nullptr;

- RefPtr<JSONObject> parsedObjectId = parsedValue->asObject();

+ RefPtr<JSONObject> parsedObjectId = JSONObject::cast(parsedValue.release());

bool success = parsedObjectId->getNumber("injectedScriptId", &m_injectedScriptId);

if (success)

return parsedObjectId.release();