Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 1730653002: Move squash preventing reasons out of compositing reasons (Closed)

Created:
4 years, 10 months ago by Ian Vollick
Modified:
4 years, 10 months ago
Reviewers:
ajuma
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, kinuko+watch, rwlbuis, krit, drott+blinkwatch_chromium.org, szager+layoutwatch_chromium.org, Justin Novosad, Rik, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, vmpstr+blinkwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, jbroman, pdr+graphicswatchlist_chromium.org, Stephen Chennney, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, blink-layers+watch_chromium.org, f(malita), danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move squash preventing reasons out of compositing reasons This is a fairly mechanical change. I've replaced all of the squashing-related compositing reasons a with a single reason. I've also added squashing disallowed reasons to capture the information we lost in the melding of compositing reasons. This caused a number of tests to bark, so I've patched them up. I've also ensured that the squashing disallowed reasons are plumbed out through the graphics layer debug info so that they still show up via about:tracing. BUG=589495 Committed: https://crrev.com/bbb70c160f08335db8258fe5319a06a51110f580 Cr-Commit-Position: refs/heads/master@{#377398}

Patch Set 1 #

Patch Set 2 : fix build errors. #

Patch Set 3 : Bug and test fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -154 lines) Patch
M third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-animated-layers.html View 1 2 1 chunk +20 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-blend-mode.html View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 2 4 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp View 1 2 3 chunks +22 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 3 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 3 chunks +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositingReasons.h View 1 2 3 chunks +34 lines, -62 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositingReasons.cpp View 1 2 1 chunk +3 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerDebugInfo.h View 1 2 4 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerDebugInfo.cpp View 1 2 3 chunks +13 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/SquashingDisallowedReasons.h View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/SquashingDisallowedReasons.cpp View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Ian Vollick
4 years, 10 months ago (2016-02-24 20:20:42 UTC) #3
ajuma
lgtm
4 years, 10 months ago (2016-02-24 20:37:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730653002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730653002/40001
4 years, 10 months ago (2016-02-24 20:49:19 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-24 22:10:52 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 22:12:34 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bbb70c160f08335db8258fe5319a06a51110f580
Cr-Commit-Position: refs/heads/master@{#377398}

Powered by Google App Engine
This is Rietveld 408576698