DevTools: simplify JSONValues API, prepare to the OwnPtr migration.

third_party/WebKit/Source/platform/JSONParserTest.cpp

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/JSONParser.h"
 
 #include "platform/JSONValues.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "wtf/text/StringBuilder.h"
 
@@ skipping 39 matching lines @@
     EXPECT_EQ(40, intVal);
     root = parseJSON("true // comment");
     ASSERT_TRUE(root.get());
     EXPECT_EQ(JSONValue::TypeBoolean, root->type());
     root = parseJSON("/* comment */\"sample string\"");
     ASSERT_TRUE(root.get());
     EXPECT_TRUE(root->asString(&strVal));
     EXPECT_EQ("sample string", strVal);
     root = parseJSON("[1, /* comment, 2 ] */ \n 3]");
     ASSERT_TRUE(root.get());
-    RefPtr<JSONArray> list;
-    ASSERT_TRUE(root->asArray(&list));
+    RefPtr<JSONArray> list = JSONArray::cast(root);
+    ASSERT_TRUE(list);
     EXPECT_EQ(2u, list->length());
     tmpValue = list->get(0);
     ASSERT_TRUE(tmpValue.get());
     EXPECT_TRUE(tmpValue->asNumber(&intVal));
     EXPECT_EQ(1, intVal);
     tmpValue = list->get(1);
     ASSERT_TRUE(tmpValue.get());
     EXPECT_TRUE(tmpValue->asNumber(&intVal));
     EXPECT_EQ(3, intVal);
     root = parseJSON("[1, /*a*/2, 3]");
     ASSERT_TRUE(root.get());
-    ASSERT_TRUE(root->asArray(&list));
+    list = JSONArray::cast(root);
+    ASSERT_TRUE(list);
     EXPECT_EQ(3u, list->length());
     root = parseJSON("/* comment **/42");
     ASSERT_TRUE(root.get());
     EXPECT_EQ(JSONValue::TypeNumber, root->type());
     EXPECT_TRUE(root->asNumber(&intVal));
     EXPECT_EQ(42, intVal);
     root = parseJSON(
         "/* comment **/\n"
         "// */ 43\n"
         "44");
@@ skipping 161 matching lines @@
     EXPECT_FALSE(root.get());
     root = parseJSON("\"not enough escape chars\\u123\"");
     EXPECT_FALSE(root.get());
     root = parseJSON("\"extra backslash at end of input\\\"");
     EXPECT_FALSE(root.get());
 
     // Basic array
     root = parseJSON("[true, false, null]");
     ASSERT_TRUE(root.get());
     EXPECT_EQ(JSONValue::TypeArray, root->type());
-    ASSERT_TRUE(root->asArray(&list));
+    list = JSONArray::cast(root);
+    ASSERT_TRUE(list);
     EXPECT_EQ(3U, list->length());
 
     // Empty array
     root = parseJSON("[]");
     ASSERT_TRUE(root.get());
     EXPECT_EQ(JSONValue::TypeArray, root->type());
-    ASSERT_TRUE(root->asArray(&list));
+    list = JSONArray::cast(root);
+    ASSERT_TRUE(list);
     EXPECT_EQ(0U, list->length());
 
     // Nested arrays
     root = parseJSON("[[true], [], [false, [], [null]], null]");
     ASSERT_TRUE(root.get());
     EXPECT_EQ(JSONValue::TypeArray, root->type());
-    ASSERT_TRUE(root->asArray(&list));
+    list = JSONArray::cast(root);
+    ASSERT_TRUE(list);
     EXPECT_EQ(4U, list->length());
 
     // Invalid, missing close brace.
     root = parseJSON("[[true], [], [false, [], [null]], null");
     EXPECT_FALSE(root.get());
 
     // Invalid, too many commas
     root = parseJSON("[true,, null]");
     EXPECT_FALSE(root.get());
 
     // Invalid, no commas
     root = parseJSON("[true null]");
     EXPECT_FALSE(root.get());
 
     // Invalid, trailing comma
     root = parseJSON("[true,]");
     EXPECT_FALSE(root.get());
 
     root = parseJSON("[true]");
     ASSERT_TRUE(root.get());
     EXPECT_EQ(JSONValue::TypeArray, root->type());
-    ASSERT_TRUE(root->asArray(&list));
+    list = JSONArray::cast(root);
+    ASSERT_TRUE(list);
     EXPECT_EQ(1U, list->length());
     tmpValue = list->get(0);
     ASSERT_TRUE(tmpValue.get());
     EXPECT_EQ(JSONValue::TypeBoolean, tmpValue->type());
     bool boolValue = false;
     EXPECT_TRUE(tmpValue->asBoolean(&boolValue));
     EXPECT_TRUE(boolValue);
 
     // Don't allow empty elements.
     root = parseJSON("[,]");
     EXPECT_FALSE(root.get());
     root = parseJSON("[true,,]");
     EXPECT_FALSE(root.get());
     root = parseJSON("[,true,]");
     EXPECT_FALSE(root.get());
     root = parseJSON("[true,,false]");
     EXPECT_FALSE(root.get());
 
     // Test objects
     root = parseJSON("{}");
     ASSERT_TRUE(root.get());
     EXPECT_EQ(JSONValue::TypeObject, root->type());
 
     root = parseJSON("{\"number\":9.87654321, \"null\":null , \"\\x53\" : \"str\" }");
     ASSERT_TRUE(root.get());
     EXPECT_EQ(JSONValue::TypeObject, root->type());
-    RefPtr<JSONObject> objectVal;
-    ASSERT_TRUE(root->asObject(&objectVal));
+    RefPtr<JSONObject> objectVal = JSONObject::cast(root);
+    ASSERT_TRUE(objectVal);
     doubleVal = 0.0;
     EXPECT_TRUE(objectVal->getNumber("number", &doubleVal));
     EXPECT_DOUBLE_EQ(9.87654321, doubleVal);
     RefPtr<JSONValue> nullVal = objectVal->get("null");
     ASSERT_TRUE(nullVal.get());
     EXPECT_EQ(JSONValue::TypeNull, nullVal->type());
     EXPECT_TRUE(objectVal->getString("S", &strVal));
     EXPECT_EQ("str", strVal);
 
     // Test newline equivalence.
@@ skipping 12 matching lines @@
         "  \"null\":null,\r\n"
         "  \"\\x53\":\"str\"\r\n"
         "}\r\n");
     ASSERT_TRUE(root2.get());
     EXPECT_EQ(root->toJSONString(), root2->toJSONString());
 
     // Test nesting
     root = parseJSON("{\"inner\":{\"array\":[true]},\"false\":false,\"d\":{}}");
     ASSERT_TRUE(root.get());
     EXPECT_EQ(JSONValue::TypeObject, root->type());
-    ASSERT_TRUE(root->asObject(&objectVal));
+    objectVal = JSONObject::cast(root);
+    ASSERT_TRUE(objectVal);
     RefPtr<JSONObject> innerObject = objectVal->getObject("inner");
     ASSERT_TRUE(innerObject.get());
     RefPtr<JSONArray> innerArray = innerObject->getArray("array");
     ASSERT_TRUE(innerArray.get());
     EXPECT_EQ(1U, innerArray->length());
     boolValue = true;
     EXPECT_TRUE(objectVal->getBoolean("false", &boolValue));
     EXPECT_FALSE(boolValue);
     innerObject = objectVal->getObject("d");
     EXPECT_TRUE(innerObject.get());
 
     // Test keys with periods
     root = parseJSON("{\"a.b\":3,\"c\":2,\"d.e.f\":{\"g.h.i.j\":1}}");
     ASSERT_TRUE(root.get());
     EXPECT_EQ(JSONValue::TypeObject, root->type());
-    ASSERT_TRUE(root->asObject(&objectVal));
+    objectVal = JSONObject::cast(root);
+    ASSERT_TRUE(objectVal);
     int integerValue = 0;
     EXPECT_TRUE(objectVal->getNumber("a.b", &integerValue));
     EXPECT_EQ(3, integerValue);
     EXPECT_TRUE(objectVal->getNumber("c", &integerValue));
     EXPECT_EQ(2, integerValue);
     innerObject = objectVal->getObject("d.e.f");
     ASSERT_TRUE(innerObject.get());
     EXPECT_EQ(1, innerObject->size());
     EXPECT_TRUE(innerObject->getNumber("g.h.i.j", &integerValue));
     EXPECT_EQ(1, integerValue);
 
     root = parseJSON("{\"a\":{\"b\":2},\"a.b\":1}");
     ASSERT_TRUE(root.get());
     EXPECT_EQ(JSONValue::TypeObject, root->type());
-    ASSERT_TRUE(root->asObject(&objectVal));
+    objectVal = JSONObject::cast(root);
+    ASSERT_TRUE(objectVal);
     innerObject = objectVal->getObject("a");
     ASSERT_TRUE(innerObject.get());
     EXPECT_TRUE(innerObject->getNumber("b", &integerValue));
     EXPECT_EQ(2, integerValue);
     EXPECT_TRUE(objectVal->getNumber("a.b", &integerValue));
     EXPECT_EQ(1, integerValue);
 
     // Invalid, no closing brace
     root = parseJSON("{\"a\": true");
     EXPECT_FALSE(root.get());
@@ skipping 37 matching lines @@
     // A few thousand adjacent lists is fine.
     StringBuilder notEvil;
     notEvil.reserveCapacity(15010);
     notEvil.append('[');
     for (int i = 0; i < 5000; ++i)
         notEvil.append("[],");
     notEvil.append("[]]");
     root = parseJSON(notEvil.toString());
     ASSERT_TRUE(root.get());
     EXPECT_EQ(JSONValue::TypeArray, root->type());
-    ASSERT_TRUE(root->asArray(&list));
+    list = JSONArray::cast(root);
+    ASSERT_TRUE(list);
     EXPECT_EQ(5001U, list->length());
 
     // Test utf8 encoded input
     root = parseJSON("\"\\xe7\\xbd\\x91\\xe9\\xa1\\xb5\"");
     ASSERT_TRUE(root.get());
     EXPECT_EQ(JSONValue::TypeString, root->type());
     EXPECT_TRUE(root->asString(&strVal));
     UChar tmp4[] = {0x7f51, 0x9875};
     EXPECT_EQ(String(tmp4, WTF_ARRAY_LENGTH(tmp4)), strVal);
 
     root = parseJSON("{\"path\": \"/tmp/\\xc3\\xa0\\xc3\\xa8\\xc3\\xb2.png\"}");
     ASSERT_TRUE(root.get());
     EXPECT_EQ(JSONValue::TypeObject, root->type());
-    EXPECT_TRUE(root->asObject(&objectVal));
+    objectVal = JSONObject::cast(root);
+    ASSERT_TRUE(objectVal);
     EXPECT_TRUE(objectVal->getString("path", &strVal));
     UChar tmp5[] = {0x2f, 0x74, 0x6d, 0x70, 0x2f, 0xe0, 0xe8, 0xf2, 0x2e, 0x70, 0x6e, 0x67};
     EXPECT_EQ(String(tmp5, WTF_ARRAY_LENGTH(tmp5)), strVal);
 
     // Test invalid utf8 encoded input
     root = parseJSON("\"345\\xb0\\xa1\\xb0\\xa2\"");
     ASSERT_FALSE(root.get());
     root = parseJSON("\"123\\xc0\\x81\"");
     ASSERT_FALSE(root.get());
     root = parseJSON("\"abc\\xc0\\xae\"");
@@ skipping 66 matching lines @@
         "//**/"
     };
 
     for (size_t i = 0; i < WTF_ARRAY_LENGTH(invalidJson); ++i) {
         RefPtr<JSONValue> result = parseJSON(invalidJson[i]);
         EXPECT_FALSE(result.get());
     }
 }
 
 } // namespace blink