[NTP Snippets] Fetch/load snippets on startup, and pass them on NTP creation

[NTP Snippets] Fetch/load snippets on startup, and pass them on NTP creation

BUG=586452
Committed: https://crrev.com/326fd3fef8ba6401af70951130ae2032ea9571d4
Cr-Commit-Position: refs/heads/master@{#377594}

[Marc Treib, 2016-02-22 14:12:58]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2016-02-22 14:12:58]

One more CL for the stack... PTAL!

https://codereview.chromium.org/1723493002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
(right):

https://codereview.chromium.org/1723493002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java:39:
if (mNativeSnippetsBridge != 0) {
Before, when we passed the observer to the constructor, we'd be called back
before mNativeSnippetsBridge was set, so we'd miss the initial set of data.

[Bernhard Bauer, 2016-02-22 14:44:01]

https://codereview.chromium.org/1723493002/diff/1/chrome/browser/android/ntp_...
File chrome/browser/android/ntp_snippets_bridge.cc (right):

https://codereview.chromium.org/1723493002/diff/1/chrome/browser/android/ntp_...
chrome/browser/android/ntp_snippets_bridge.cc:31:
NTPSnippetsBridge::NTPSnippetsBridge(JNIEnv* env, jobject j_profile)
All of these should be JavaParamRef<jobject>, BTW.

https://codereview.chromium.org/1723493002/diff/1/chrome/browser/android/ntp_...
File chrome/browser/android/ntp_snippets_bridge.h (right):

https://codereview.chromium.org/1723493002/diff/1/chrome/browser/android/ntp_...
chrome/browser/android/ntp_snippets_bridge.h:18: explicit
NTPSnippetsBridge(JNIEnv* env, jobject j_profile);
Explicit isn't necessary for multi-argument constructors (not that it was
necessary before).

[Marc Treib, 2016-02-22 17:22:49]

https://codereview.chromium.org/1723493002/diff/1/chrome/browser/android/ntp_...
File chrome/browser/android/ntp_snippets_bridge.cc (right):

https://codereview.chromium.org/1723493002/diff/1/chrome/browser/android/ntp_...
chrome/browser/android/ntp_snippets_bridge.cc:31:
NTPSnippetsBridge::NTPSnippetsBridge(JNIEnv* env, jobject j_profile)
On 2016/02/22 14:44:01, Bernhard Bauer wrote:
> All of these should be JavaParamRef<jobject>, BTW.

Done. (Why don't we have some check for this?)

https://codereview.chromium.org/1723493002/diff/1/chrome/browser/android/ntp_...
File chrome/browser/android/ntp_snippets_bridge.h (right):

https://codereview.chromium.org/1723493002/diff/1/chrome/browser/android/ntp_...
chrome/browser/android/ntp_snippets_bridge.h:18: explicit
NTPSnippetsBridge(JNIEnv* env, jobject j_profile);
On 2016/02/22 14:44:01, Bernhard Bauer wrote:
> Explicit isn't necessary for multi-argument constructors (not that it was
> necessary before).

Done.

[Marc Treib, 2016-02-24 14:24:06]

Ping! Still missing an lgtm here ;)

[Bernhard Bauer, 2016-02-24 16:10:45]

LGTM -- sorry for the delay.

[Marc Treib, 2016-02-25 15:48:12]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2016-02-25 15:48:13]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/1723493002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-02-25 15:48:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1723493002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1723493002/80001

[commit-bot: I haz the power, 2016-02-25 16:36:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 16:36:34]

Exceeded global retry quota

[Marc Treib, 2016-02-25 16:46:46]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2016-02-25 16:47:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1723493002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1723493002/80001

[commit-bot: I haz the power, 2016-02-25 16:59:02]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-25 17:00:18]

Description was changed from

==========
[NTP Snippets] Fetch/load snippets on startup, and pass them on NTP creation

BUG=586452
==========

to

==========
[NTP Snippets] Fetch/load snippets on startup, and pass them on NTP creation

BUG=586452

Committed: https://crrev.com/326fd3fef8ba6401af70951130ae2032ea9571d4
Cr-Commit-Position: refs/heads/master@{#377594}
==========

[commit-bot: I haz the power, 2016-02-25 17:00:19]

Patchset 5 (id:??) landed as
https://crrev.com/326fd3fef8ba6401af70951130ae2032ea9571d4
Cr-Commit-Position: refs/heads/master@{#377594}