chrome/browser/android/ntp_snippets_bridge.h - Issue 1723493002: [NTP Snippets] Fetch/load snippets on startup, and pass them on NTP creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/ntp_snippets_bridge.h

Issue 1723493002: [NTP Snippets] Fetch/load snippets on startup, and pass them on NTP creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gcmtaskservice

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java ('k') | chrome/browser/android/ntp_snippets_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/ntp_snippets_bridge.h

diff --git a/chrome/browser/android/ntp_snippets_bridge.h b/chrome/browser/android/ntp_snippets_bridge.h

index 727cd27428c0b3da0a07a161f571ae268dbd7568..97ed187ba8bb12da7a1765e25afe633b183bed4b 100644

--- a/chrome/browser/android/ntp_snippets_bridge.h

+++ b/chrome/browser/android/ntp_snippets_bridge.h

@@ -15,11 +15,14 @@

// the list of snippets to show on the NTP

class NTPSnippetsBridge : public ntp_snippets::NTPSnippetsServiceObserver {

public:

- explicit NTPSnippetsBridge(JNIEnv* env,

- jobject j_profile,

- jobject j_observer);

+ NTPSnippetsBridge(JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& j_profile);

void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);

+ void SetObserver(JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& obj,

+ const base::android::JavaParamRef<jobject>& j_observer);

static bool Register(JNIEnv* env);

private: