Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: chrome/browser/android/ntp_snippets_bridge.cc

Issue 1723493002: [NTP Snippets] Fetch/load snippets on startup, and pass them on NTP creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gcmtaskservice
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/ntp_snippets_bridge.h ('k') | components/ntp_snippets/ntp_snippets_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/ntp_snippets_bridge.cc
diff --git a/chrome/browser/android/ntp_snippets_bridge.cc b/chrome/browser/android/ntp_snippets_bridge.cc
index 1613ae42ccfc53b914c0580ad4808cf8d0968d2b..cbb55c835dfaa771231bbd562924d2dc4edf4f7e 100644
--- a/chrome/browser/android/ntp_snippets_bridge.cc
+++ b/chrome/browser/android/ntp_snippets_bridge.cc
@@ -23,22 +23,24 @@ using ntp_snippets::NTPSnippetsServiceObserver;
static jlong Init(JNIEnv* env,
const JavaParamRef<jobject>& obj,
- const JavaParamRef<jobject>& j_profile,
- const JavaParamRef<jobject>& j_observer) {
- NTPSnippetsBridge* snippets_bridge =
- new NTPSnippetsBridge(env, j_profile, j_observer);
+ const JavaParamRef<jobject>& j_profile) {
+ NTPSnippetsBridge* snippets_bridge = new NTPSnippetsBridge(env, j_profile);
return reinterpret_cast<intptr_t>(snippets_bridge);
}
NTPSnippetsBridge::NTPSnippetsBridge(JNIEnv* env,
- jobject j_profile,
- jobject j_observer)
+ const JavaParamRef<jobject>& j_profile)
: snippet_service_observer_(this) {
- observer_.Reset(env, j_observer);
-
Profile* profile = ProfileAndroid::FromProfileAndroid(j_profile);
ntp_snippets_service_ = NTPSnippetsServiceFactory::GetForProfile(profile);
snippet_service_observer_.Add(ntp_snippets_service_);
+}
+
+void NTPSnippetsBridge::SetObserver(JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jobject>& j_observer) {
+ observer_.Reset(env, j_observer);
+
if (ntp_snippets_service_->is_loaded())
NTPSnippetsServiceLoaded(ntp_snippets_service_);
}
« no previous file with comments | « chrome/browser/android/ntp_snippets_bridge.h ('k') | components/ntp_snippets/ntp_snippets_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698