[NTP Snippets] Fetch/load snippets on startup, and pass them on NTP creation

chrome/browser/android/ntp_snippets_bridge.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/ntp_snippets_bridge.h"
 
 #include <jni.h>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/scoped_java_ref.h"
 #include "chrome/browser/ntp_snippets/ntp_snippets_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_android.h"
 #include "components/ntp_snippets/ntp_snippet.h"
 #include "components/ntp_snippets/ntp_snippets_service.h"
 #include "jni/SnippetsBridge_jni.h"
 
 using base::android::JavaParamRef;
 using base::android::ToJavaArrayOfStrings;
 using ntp_snippets::NTPSnippetsService;
 using ntp_snippets::NTPSnippetsServiceObserver;
 
 static jlong Init(JNIEnv* env,
                   const JavaParamRef<jobject>& obj,
-                  const JavaParamRef<jobject>& j_profile,
-                  const JavaParamRef<jobject>& j_observer) {
-  NTPSnippetsBridge* snippets_bridge =
-      new NTPSnippetsBridge(env, j_profile, j_observer);
+                  const JavaParamRef<jobject>& j_profile) {
+  NTPSnippetsBridge* snippets_bridge = new NTPSnippetsBridge(env, j_profile);
   return reinterpret_cast<intptr_t>(snippets_bridge);
 }
 
-NTPSnippetsBridge::NTPSnippetsBridge(JNIEnv* env,
-                                     jobject j_profile,
-                                     jobject j_observer)
+NTPSnippetsBridge::NTPSnippetsBridge(JNIEnv* env, jobject j_profile)

[Bernhard Bauer, 2016/02/22 14:44:01]

All of these should be JavaParamRef<jobject>, BTW.

[Marc Treib, 2016/02/22 17:22:49]

Done. (Why don't we have some check for this?)

     : snippet_service_observer_(this) {
-  observer_.Reset(env, j_observer);
-
   Profile* profile = ProfileAndroid::FromProfileAndroid(j_profile);
   ntp_snippets_service_ = NTPSnippetsServiceFactory::GetForProfile(profile);
   snippet_service_observer_.Add(ntp_snippets_service_);
+}
+
+void NTPSnippetsBridge::SetObserver(
+    JNIEnv* env,
+    const base::android::JavaParamRef<jobject>& obj,
+    jobject j_observer) {
+  observer_.Reset(env, j_observer);
+
   if (ntp_snippets_service_->is_loaded())
     NTPSnippetsServiceLoaded(ntp_snippets_service_);
 }
 
 NTPSnippetsBridge::~NTPSnippetsBridge() {}
 
 void NTPSnippetsBridge::Destroy(JNIEnv* env, const JavaParamRef<jobject>& obj) {
   delete this;
 }
 
@@ skipping 23 matching lines @@
 void NTPSnippetsBridge::NTPSnippetsServiceShutdown(
     NTPSnippetsService* service) {
   observer_.Reset();
   snippet_service_observer_.Remove(ntp_snippets_service_);
 }
 
 // static
 bool NTPSnippetsBridge::Register(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }