Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3045)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 1723493002: [NTP Snippets] Fetch/load snippets on startup, and pass them on NTP creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gcmtaskservice
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/ntp_snippets_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
index db0b5ad6a0c7b36af7ea2ecdc65e58d344de0bc0..64df7d0bf5ecc2e80aad60215441f03e8382f19b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
@@ -30,6 +30,7 @@ public class SnippetsBridge {
* @param profile Profile of the user that we will retrieve snippets for.
*/
public SnippetsBridge(Profile profile, final SnippetsObserver observer) {
+ mNativeSnippetsBridge = nativeInit(profile);
SnippetsObserver wrappedObserver = new SnippetsObserver() {
@Override
public void onSnippetsAvailable(
@@ -40,7 +41,7 @@ public class SnippetsBridge {
}
}
};
- mNativeSnippetsBridge = nativeInit(profile, wrappedObserver);
+ nativeSetObserver(mNativeSnippetsBridge, wrappedObserver);
}
void destroy() {
@@ -49,6 +50,7 @@ public class SnippetsBridge {
mNativeSnippetsBridge = 0;
}
- private native long nativeInit(Profile profile, SnippetsObserver observer);
+ private native long nativeInit(Profile profile);
private native void nativeDestroy(long nativeNTPSnippetsBridge);
+ private native void nativeSetObserver(long nativeNTPSnippetsBridge, SnippetsObserver observer);
}
« no previous file with comments | « no previous file | chrome/browser/android/ntp_snippets_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698