Issue 171423019: Revert 167539 "Updating Blink-side Gamepad API to match latest spec"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 171423019: Revert 167539 "Updating Blink-side Gamepad API to match latest spec" (Closed)

Created:
6 years, 10 months ago by bajones

Modified:
6 years, 10 months ago

Reviewers:
bajones

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

Revert 167539 "Updating Blink-side Gamepad API to match latest spec" Compiler errors introduced on Blink waterfall > Updating Blink-side Gamepad API to match latest spec > > BUG=344556 > R=abarth@chromium.org, scottmg@chromium.org > > Review URL: https://codereview.chromium.org/170993002 TBR=bajones@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167541

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -132 lines)			Patch
M	trunk/Source/build/features.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/Source/modules/gamepad/Gamepad.h	View	4 chunks	+3 lines, -14 lines	0 comments	Download
M	trunk/Source/modules/gamepad/Gamepad.cpp	View	1 chunk	+4 lines, -11 lines	0 comments	Download
M	trunk/Source/modules/gamepad/Gamepad.idl	View	1 chunk	+1 line, -3 lines	0 comments	Download
D	trunk/Source/modules/gamepad/GamepadButton.h	View	1 chunk	+0 lines, -36 lines	0 comments	Download
D	trunk/Source/modules/gamepad/GamepadButton.cpp	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	trunk/Source/modules/gamepad/GamepadButton.idl	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	trunk/Source/modules/gamepad/NavigatorGamepad.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/Source/modules/modules.gypi	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/public/platform/WebGamepad.h	View	3 chunks	+3 lines, -24 lines	0 comments	Download
M	trunk/public/platform/WebGamepads.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r167541.