Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1713503002: Reland Allow one-copy and zero-copy task tile worker pools to use compressed textures. (Closed)

Created:
4 years, 10 months ago by auygun
Modified:
4 years, 10 months ago
CC:
anandc+watch-blimp_chromium.org, cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, jam, jbauman+watch_chromium.org, kalyank, kmarshall+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nyquist+watch-blimp_chromium.org, peterp, piman+watch_chromium.org, sievers+watch_chromium.org, sriramsr+watch-blimp_chromium.org, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland Allow one-copy and zero-copy task tile worker pools to use compressed textures. BUG=434699 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/2cb89894001edd7dd1c3a1c051de76d65b0d9ff8 Cr-Commit-Position: refs/heads/master@{#376711}

Patch Set 1 : Original CL rebased on latest master #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -113 lines) Patch
M blimp/client/feature/compositor/blimp_layer_tree_settings.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/base/switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/base/switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 3 chunks +6 lines, -4 lines 0 comments Download
M cc/output/renderer_settings.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/output/renderer_settings.cc View 5 chunks +11 lines, -6 lines 0 comments Download
M cc/output/renderer_settings_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/proto/renderer_settings.proto View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/raster/one_copy_tile_task_worker_pool.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/raster/one_copy_tile_task_worker_pool.cc View 5 chunks +44 lines, -32 lines 0 comments Download
M cc/raster/tile_task_worker_pool.cc View 4 chunks +52 lines, -25 lines 0 comments Download
M cc/raster/tile_task_worker_pool_perftest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/raster/tile_task_worker_pool_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/raster/zero_copy_tile_task_worker_pool.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/raster/zero_copy_tile_task_worker_pool.cc View 2 chunks +13 lines, -9 lines 0 comments Download
M cc/resources/platform_color.h View 1 chunk +13 lines, -1 line 0 comments Download
M cc/resources/resource_format.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/resources/resource_format.cc View 2 chunks +24 lines, -1 line 0 comments Download
M cc/resources/resource_provider.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/resources/resource_provider.cc View 2 chunks +29 lines, -3 lines 0 comments Download
M cc/test/layer_tree_pixel_resource_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M cc/tiles/tile_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 chunks +13 lines, -7 lines 0 comments Download
M ui/compositor/compositor.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
auygun
This is a reland of https://codereview.chromium.org/1379783002/ Patch 1 is the original CL (that landed and ...
4 years, 10 months ago (2016-02-18 11:59:44 UTC) #5
reveman
lgtm did you change anything to make the test pass?
4 years, 10 months ago (2016-02-18 13:20:10 UTC) #6
auygun
On 2016/02/18 13:20:10, reveman wrote: > lgtm > > did you change anything to make ...
4 years, 10 months ago (2016-02-18 13:32:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713503002/1
4 years, 10 months ago (2016-02-18 13:41:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/147345)
4 years, 10 months ago (2016-02-18 13:50:27 UTC) #11
auygun
piman, sievers, nyquist would you please have a look?
4 years, 10 months ago (2016-02-18 15:25:35 UTC) #13
piman
lgtm
4 years, 10 months ago (2016-02-18 17:50:08 UTC) #14
nyquist
blimp lgtm
4 years, 10 months ago (2016-02-18 23:55:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713503002/1
4 years, 10 months ago (2016-02-19 10:04:00 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/147819)
4 years, 10 months ago (2016-02-19 10:16:08 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713503002/20001
4 years, 10 months ago (2016-02-22 09:56:01 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-22 11:09:48 UTC) #24
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 11:11:11 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2cb89894001edd7dd1c3a1c051de76d65b0d9ff8
Cr-Commit-Position: refs/heads/master@{#376711}

Powered by Google App Engine
This is Rietveld 408576698