Issue 170453004: Add constant twoPiDouble/twoPiFloat to MathExtras.h

Issue 170453004: Add constant twoPiDouble/twoPiFloat to MathExtras.h (Closed)

Created:
6 years, 10 months ago by zino

Modified:
6 years, 10 months ago

Reviewers:
Justin Novosad, eseidel

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add constant twoPiDouble/twoPiFloat to MathExtras.h piDouble/piFloat * 2 is often used in Blink. So, if we add constant values to MathExtras.h, we will be able to use them usefully. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167783

Patch Set 1 #

Total comments: 1

Patch Set 2 : add constant values to header #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -52 lines)			Patch
M	Source/core/html/canvas/CanvasPathMethods.cpp	View	1	6 chunks	+13 lines, -16 lines	0 comments	Download
M	Source/core/rendering/shapes/PolygonShape.cpp	View	1	1 chunk	+4 lines, -5 lines	0 comments	Download
M	Source/core/svg/SVGPathParser.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/modules/webaudio/RealtimeAnalyser.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/audio/DownSampler.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/audio/DynamicsCompressorKernel.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/platform/audio/EqualPowerPanner.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/platform/audio/FFTFrame.cpp	View	1	5 chunks	+12 lines, -12 lines	0 comments	Download
M	Source/platform/audio/SincResampler.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/audio/UpSampler.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/graphics/Path.cpp	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/platform/graphics/filters/FEGaussianBlur.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/transforms/AffineTransform.cpp	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/wtf/MathExtras.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Justin Novosad

https://codereview.chromium.org/170453004/diff/1/Source/platform/transforms/AffineTransform.cpp File Source/platform/transforms/AffineTransform.cpp (right): https://codereview.chromium.org/170453004/diff/1/Source/platform/transforms/AffineTransform.cpp#newcode320 Source/platform/transforms/AffineTransform.cpp:320: const double twoPiDouble = piDouble * 2; Does this ...

6 years, 10 months ago (2014-02-20 19:38:05 UTC) #2

zino

On 2014/02/20 19:38:05, junov wrote: > https://codereview.chromium.org/170453004/diff/1/Source/platform/transforms/AffineTransform.cpp > File Source/platform/transforms/AffineTransform.cpp (right): > > https://codereview.chromium.org/170453004/diff/1/Source/platform/transforms/AffineTransform.cpp#newcode320 > ...

6 years, 10 months ago (2014-02-22 14:42:05 UTC) #3

Justin Novosad

On 2014/02/22 14:42:05, zino wrote: > On 2014/02/20 19:38:05, junov wrote: > > > https://codereview.chromium.org/170453004/diff/1/Source/platform/transforms/AffineTransform.cpp ...

6 years, 10 months ago (2014-02-24 16:17:59 UTC) #4

zino

I just stumbled on it when I was working on other patch. I had realized ...

6 years, 10 months ago (2014-02-25 08:10:42 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/170453004/70001

6 years, 10 months ago (2014-02-25 08:13:30 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/170453004/70001

6 years, 10 months ago (2014-02-25 13:26:52 UTC) #8

Message was sent while issue was closed.

Change committed as 167783

Expand Messages | Collapse Messages