Source/platform/audio/SincResampler.cpp - Issue 170453004: Add constant twoPiDouble/twoPiFloat to MathExtras.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/audio/SincResampler.cpp

Issue 170453004: Add constant twoPiDouble/twoPiFloat to MathExtras.h (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add constant values to header Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/audio/SincResampler.cpp

diff --git a/Source/platform/audio/SincResampler.cpp b/Source/platform/audio/SincResampler.cpp

index c0414ebbceac9e6f1e85834881aa9943fe34f3de..7f76d72ca09ca2155ae42415d0d8de2a0eede6d8 100644

--- a/Source/platform/audio/SincResampler.cpp

+++ b/Source/platform/audio/SincResampler.cpp

@@ -119,7 +119,7 @@ void SincResampler::initializeKernel()

// Compute Blackman window, matching the offset of the sinc().

double x = (i - subsampleOffset) / n;

- double window = a0 - a1 * cos(2.0 * piDouble * x) + a2 * cos(4.0 * piDouble * x);

+ double window = a0 - a1 * cos(twoPiDouble * x) + a2 * cos(twoPiDouble * 2.0 * x);

// Window the sinc() function and store at the correct offset.

m_kernelStorage[i + offsetIndex * m_kernelSize] = sinc * window;

« no previous file with comments | « Source/platform/audio/FFTFrame.cpp ('k') | Source/platform/audio/UpSampler.cpp » ('j') | no next file with comments »