Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 170283006: [Telemetry] Don't create a new Tab object at each navigation. (Closed)

Created:
6 years, 10 months ago by tonyg
Modified:
6 years, 10 months ago
Reviewers:
achuithb, dtu
CC:
chromium-reviews, chrome-speed-team+watch_google.com, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Don't create a new Tab object at each navigation. This patch prevents us from constructing a new Tab object at each navigation which permits the tab contents video capture API to cache its tab contents bounding box. I also suspect it might help with flake and noise as we no longer connect and disconnect so frequently and no longer depend on the python GC to do so. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252246

Patch Set 1 #

Patch Set 2 : Remove unused method #

Total comments: 1

Messages

Total messages: 10 (0 generated)
tonyg
6 years, 10 months ago (2014-02-18 23:49:52 UTC) #1
dtu
This is a great cleanup. Hope it sticks. https://chromiumcodereview.appspot.com/170283006/diff/40001/tools/telemetry/telemetry/core/backends/chrome/tab_list_backend.py File tools/telemetry/telemetry/core/backends/chrome/tab_list_backend.py (right): https://chromiumcodereview.appspot.com/170283006/diff/40001/tools/telemetry/telemetry/core/backends/chrome/tab_list_backend.py#newcode20 tools/telemetry/telemetry/core/backends/chrome/tab_list_backend.py:20: self._tab_dict ...
6 years, 10 months ago (2014-02-19 23:39:27 UTC) #2
dtu
On 2014/02/19 23:39:27, dtu wrote: > This is a great cleanup. Hope it sticks. > ...
6 years, 10 months ago (2014-02-19 23:39:51 UTC) #3
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 10 months ago (2014-02-19 23:49:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/170283006/40001
6 years, 10 months ago (2014-02-20 01:20:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/170283006/40001
6 years, 10 months ago (2014-02-20 05:08:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/170283006/40001
6 years, 10 months ago (2014-02-20 09:04:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/170283006/40001
6 years, 10 months ago (2014-02-20 12:27:35 UTC) #8
commit-bot: I haz the power
Change committed as 252246
6 years, 10 months ago (2014-02-20 15:54:22 UTC) #9
achuithb
6 years, 10 months ago (2014-02-20 20:02:35 UTC) #10
Message was sent while issue was closed.
I suspect this CL broke ~12 telemetry unit tests on cros:
http://chromegw.corp.google.com/i/chromium.fyi/builders/Chromium%20Cros64%20P...

We really need a cros try server!!

(cros chrome bots are fine)

Powered by Google App Engine
This is Rietveld 408576698