tools/telemetry/telemetry/page/page_runner.py - Issue 170283006: [Telemetry] Don't create a new Tab object at each navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 170283006: [Telemetry] Don't create a new Tab object at each navigation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove unused method Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index cde1ae3032c6f781e77a6b3a9e3a5c829c115195..64f1caa76e4c3a2bf5f29e52dd4e4fe4741a3f0c 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -178,10 +178,6 @@ class PageState(object):

self.tab.browser.credentials.LoginNoLongerNeeded(

self.tab, self.page.credentials)

- if self.tab:

- self.tab.Disconnect()

- self.tab = None

def AddCommandLineOptions(parser):

page_filter_module.PageFilter.AddCommandLineOptions(parser)