tools/telemetry/telemetry/core/tab_unittest.py - Issue 170283006: [Telemetry] Don't create a new Tab object at each navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/tab_unittest.py

Issue 170283006: [Telemetry] Don't create a new Tab object at each navigation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove unused method Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/core/tab_unittest.py

diff --git a/tools/telemetry/telemetry/core/tab_unittest.py b/tools/telemetry/telemetry/core/tab_unittest.py

index a58d9e73f256edef9b343e99266fb0481a0f57da..c5d4428710ac6c457c109aee6b2aedd908d84833 100644

--- a/tools/telemetry/telemetry/core/tab_unittest.py

+++ b/tools/telemetry/telemetry/core/tab_unittest.py

@@ -11,10 +11,7 @@ from telemetry.unittest import tab_test_case

def _IsDocumentVisible(tab):

- hidden = tab.EvaluateJavaScript('document.hidden || document.webkitHidden')

- # TODO(dtu): Remove when crbug.com/166243 is fixed.

- tab.Disconnect()

- return not hidden

+ return not tab.EvaluateJavaScript('document.hidden || document.webkitHidden')

class TabTest(tab_test_case.TabTestCase):