Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: tools/telemetry/telemetry/core/extension_unittest.py

Issue 170283006: [Telemetry] Don't create a new Tab object at each navigation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unused method Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/extension_unittest.py
diff --git a/tools/telemetry/telemetry/core/extension_unittest.py b/tools/telemetry/telemetry/core/extension_unittest.py
index 31f1e1b36fb4932b0bac2b81ebd07c223deae9be..bc5fd78ded9ab7e69a92fe78338af99f014f7bf7 100644
--- a/tools/telemetry/telemetry/core/extension_unittest.py
+++ b/tools/telemetry/telemetry/core/extension_unittest.py
@@ -50,15 +50,6 @@ class ExtensionTest(unittest.TestCase):
self.assertEquals('abcdef',
self._extension.EvaluateJavaScript('_testVar'))
- def testDisconnect(self):
- """Test that ExtensionPage.Disconnect exists by calling it.
- EvaluateJavaScript should reconnect."""
- if not self._extension:
- logging.warning('Did not find a browser that supports extensions, '
- 'skipping test.')
- return
- self._extension.Disconnect()
- self.assertEquals(2, self._extension.EvaluateJavaScript('1+1'))
class NonExistentExtensionTest(unittest.TestCase):
def testNonExistentExtensionPath(self):

Powered by Google App Engine
This is Rietveld 408576698