tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py - Issue 170283006: [Telemetry] Don't create a new Tab object at each navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py

Issue 170283006: [Telemetry] Don't create a new Tab object at each navigation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove unused method Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/backends/chrome/tab_list_backend.py ('K') | « tools/telemetry/telemetry/core/backends/chrome/tab_list_backend.py ('k') | tools/telemetry/telemetry/core/extension_page.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py

index e566e35f6cf4d5f07c0c9e113e6fbde80f7a3566..c65f70b3cd291b4686cc72fcf3481d1ba15da99a 100644

--- a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py

+++ b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py

@@ -11,9 +11,6 @@ class WebDriverTabBackend(object):

self._browser_backend = browser_backend

self._window_handle = window_handle

- def Disconnect(self):

- pass

@property

def browser(self):

return self._browser_backend.browser