blitters for sRGB and float16

blitters for sRGB and float16

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1697863002

Committed: https://skia.googlesource.com/skia/+/a34be68a7eff0ae475b194f8a29975460cf3e456

[reed2, 2016-02-13 21:29:01]

Description was changed from

==========
raster blitters for 64bit targets

BUG=skia:
==========

to

==========
raster blitters for 64bit targets

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed2, 2016-02-13 21:29:16]

The CQ bit was checked by reed@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-13 21:29:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697863002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697863002/1

[commit-bot: I haz the power, 2016-02-13 21:52:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-13 21:52:57]

Dry run: This issue passed the CQ dry run.

[reed2, 2016-02-14 21:31:22]

reed@chromium.org changed reviewers:
+ fmalita@chromium.org

[reed2, 2016-02-15 02:51:35]

The CQ bit was checked by reed@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-15 02:51:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697863002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697863002/60001

[reed2, 2016-02-15 03:00:00]

The CQ bit was checked by reed@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-15 03:00:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697863002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697863002/80001

[reed2, 2016-02-15 03:09:02]

should allow us to test sRGB and half-float at runtime in SampleApp (added the
'C' key to switch configs)

ptal

[reed2, 2016-02-15 03:19:51]

Description was changed from

==========
raster blitters for 64bit targets

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
blitters for sRGB and float16

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-02-15 03:21:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-15 03:21:43]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-02-15 04:31:17]

w00t!  LGTM

https://codereview.chromium.org/1697863002/diff/80001/src/core/SkBlitter.cpp
File src/core/SkBlitter.cpp (right):

https://codereview.chromium.org/1697863002/diff/80001/src/core/SkBlitter.cpp#...
src/core/SkBlitter.cpp:29: #endif
I think we no longer need these.

https://codereview.chromium.org/1697863002/diff/80001/src/core/SkBlitter_PM4f...
File src/core/SkBlitter_PM4f.cpp (right):

https://codereview.chromium.org/1697863002/diff/80001/src/core/SkBlitter_PM4f...
src/core/SkBlitter_PM4f.cpp:139: if (!fConstInY) {
Is it worth hoisting this conditional out?  I imagine horizontal linear
gradients would benefit, if we mark them const-in-y.

https://codereview.chromium.org/1697863002/diff/80001/src/core/SkBlitter_PM4f...
src/core/SkBlitter_PM4f.cpp:159: if (!fConstInY) {
Ditto.

[reed2, 2016-02-15 15:25:22]

https://codereview.chromium.org/1697863002/diff/80001/src/core/SkBlitter.cpp
File src/core/SkBlitter.cpp (right):

https://codereview.chromium.org/1697863002/diff/80001/src/core/SkBlitter.cpp#...
src/core/SkBlitter.cpp:29: #endif
On 2016/02/15 04:31:17, f(malita) wrote:
> I think we no longer need these.

Agreed. Replaced with SK_FORCE_PM4f_FOR_L32_BLITS so we can manually test the
new code-path on old surfaces (linear 32)

https://codereview.chromium.org/1697863002/diff/80001/src/core/SkBlitter_PM4f...
File src/core/SkBlitter_PM4f.cpp (right):

https://codereview.chromium.org/1697863002/diff/80001/src/core/SkBlitter_PM4f...
src/core/SkBlitter_PM4f.cpp:139: if (!fConstInY) {
On 2016/02/15 04:31:17, f(malita) wrote:
> Is it worth hoisting this conditional out?  I imagine horizontal linear
> gradients would benefit, if we mark them const-in-y.

Was trying to keep everything very succinct until we profiled more. So far there
is no time spent here in the blitter ('cause the procs are so slow).

[reed2, 2016-02-15 15:25:32]

The CQ bit was checked by reed@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-15 15:25:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697863002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697863002/100001

[reed2, 2016-02-15 15:42:01]

The CQ bit was unchecked by reed@chromium.org

[reed2, 2016-02-15 15:42:06]

The CQ bit was checked by reed@chromium.org

[reed2, 2016-02-15 15:42:07]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1697863002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-02-15 15:42:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1697863002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1697863002/100001

[commit-bot: I haz the power, 2016-02-15 15:48:38]

Description was changed from

==========
blitters for sRGB and float16

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
blitters for sRGB and float16

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a34be68a7eff0ae475b194f8a29975460cf3e456
==========

[commit-bot: I haz the power, 2016-02-15 15:48:39]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/a34be68a7eff0ae475b194f8a29975460cf3e456