Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1697603002: Use LeakCanary for all Android Service instances

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
Yaron
CC:
chromium-reviews, davidben+watch_chromium.org, cbentzel+watch_chromium.org, sadrul, zea+watch_chromium.org, vmpstr+watch_chromium.org, tburkard+watch_chromium.org, gavinp+prer_chromium.org, kalyank, wifiprefetch-reviews_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@leak-canary-3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use LeakCanary for all Android Service instances BUG=505909

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -13 lines) Patch
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A base/android/java/src/org/chromium/base/LeakCanaryUtil.java View 1 chunk +44 lines, -0 lines 0 comments Download
M base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncherService.java View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpPreparationService.java View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java View 2 chunks +2 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/prerender/ChromePrerenderService.java View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/services/gcm/ChromeGcmListenerService.java View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/services/gcm/InvalidationGcmUpstreamSender.java View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (1 generated)
agrieve
Still a work in progress. Before I go and do all the services (~34), let ...
4 years, 10 months ago (2016-02-13 01:09:50 UTC) #2
agrieve
On 2016/02/13 01:09:50, agrieve wrote: > Still a work in progress. > > Before I ...
4 years, 10 months ago (2016-02-13 01:11:45 UTC) #3
Yaron
4 years, 10 months ago (2016-02-16 20:24:17 UTC) #4
approach seems good to me. agree that 400 bytes isn't a big issue. I naively
hoped that proguard would remove functions that just call super

Powered by Google App Engine
This is Rietveld 408576698