chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncherService.java - Issue 1697603002: Use LeakCanary for all Android Service instances

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncherService.java

Issue 1697603002: Use LeakCanary for all Android Service instances Base URL: https://chromium.googlesource.com/chromium/src.git@leak-canary-3

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/BUILD.gn ('k') | chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpPreparationService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncherService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncherService.java b/chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncherService.java

index a6219fd1868d9300af1d642f605d95b7f93b4152..9f951e981a74951fe856406f656c64edf234d2bc 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncherService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/BackgroundSyncLauncherService.java

@@ -10,6 +10,7 @@ import com.google.android.gms.gcm.GcmNetworkManager;

import com.google.android.gms.gcm.GcmTaskService;

import com.google.android.gms.gcm.TaskParams;

+import org.chromium.base.LeakCanaryUtil;

import org.chromium.base.Log;

import org.chromium.base.ThreadUtils;

import org.chromium.base.VisibleForTesting;

@@ -27,6 +28,12 @@ public class BackgroundSyncLauncherService extends GcmTaskService {

private static final String TAG = "BgSyncLauncher";

@Override

+ public void onDestroy() {

+ super.onDestroy();

+ LeakCanaryUtil.watch(this);

+ }

+ @Override

@VisibleForTesting

public int onRunTask(TaskParams params) {

// Start the browser. The browser's BackgroundSyncManager (for the active profile) will