Hook up LeakCanary to ChromePublic.apk (behind a GN arg)

Hook up LeakCanary to ChromePublic.apk

It's currently hidden behind a GN arg: enable_leakcanary.
I hope to make it default to is_debug in the (near) future.

It just detects leaked Activities right now. I'll work on having
it detect other leaked Contexts next.

classes.dex size before change: 6090704
classes.dex size after change: 6090708

BUG=505909
Committed: https://crrev.com/dfec4d0d38ee352d967dabfe46e0a7727619ce02
Cr-Commit-Position: refs/heads/master@{#377356}

[agrieve, 2016-02-12 02:29:11]

Description was changed from

==========
Hook up LeakCanary to ChromePublic.apk (behind a GN arg)

Disabled by default for now. Will make it default to is_debug in a
subsequent commit.

BUG=505909
==========

to

==========
Hook up LeakCanary to ChromePublic.apk

It's currently hidden behind a GN arg: enable_leakcanary.
I hope to make it default to is_debug in the (near) future.

It just detects leaked Activities right now. I'll work on having
it detect other leaked Contexts next.

classes.dex size before change: 6090704
classes.dex size after change: 6090708

BUG=505909
==========

[agrieve, 2016-02-12 02:30:19]

agrieve@chromium.org changed reviewers:
+ thakis@chromium.org, yfriedman@chromium.org

[agrieve, 2016-02-12 02:30:19]

yfriedman@chromium.org: Please review everything.

thakis@chromium.org: Please review chrome/chrome.gyp

[Nico, 2016-02-12 02:35:45]

chrome.gyp lgtm

[Yaron, 2016-02-12 03:01:41]

https://codereview.chromium.org/1691993003/diff/20001/chrome/android/java/And...
File chrome/android/java/AndroidManifest.xml (right):

https://codereview.chromium.org/1691993003/diff/20001/chrome/android/java/And...
chrome/android/java/AndroidManifest.xml:728:
android:name="com.squareup.leakcanary.DisplayLeakService"
can we put everything leakcanary in a separate process? I'd suggest making above
:leakcanary_heapanalyzer and all of these should have leakcanary process

https://codereview.chromium.org/1691993003/diff/20001/chrome/android/java/And...
chrome/android/java/AndroidManifest.xml:740: <category
android:name="android.intent.category.LAUNCHER" />
does this need to be in launcher? I thought it intents to itself when the leak
is hit?
is it helpful to open leak canary separately?

[agrieve, 2016-02-12 18:24:58]

https://codereview.chromium.org/1691993003/diff/20001/chrome/android/java/And...
File chrome/android/java/AndroidManifest.xml (right):

https://codereview.chromium.org/1691993003/diff/20001/chrome/android/java/And...
chrome/android/java/AndroidManifest.xml:728:
android:name="com.squareup.leakcanary.DisplayLeakService"
On 2016/02/12 03:01:41, Yaron wrote:
> can we put everything leakcanary in a separate process? I'd suggest making
above
> :leakcanary_heapanalyzer and all of these should have leakcanary process

Worked fine to move this one there as well. Going to leave the overlay activity
(added a comment).

https://codereview.chromium.org/1691993003/diff/20001/chrome/android/java/And...
chrome/android/java/AndroidManifest.xml:740: <category
android:name="android.intent.category.LAUNCHER" />
On 2016/02/12 03:01:41, Yaron wrote:
> does this need to be in launcher? I thought it intents to itself when the leak
> is hit?
> is it helpful to open leak canary separately?

The notification takes you here, but after that there's no way to look a the
leaks without this. I've tweaked it to use the app's name and not be disabled to
make it play more likely when multiple apks have leakcanary enabled. It being
disabled meant the icon wasn't there until the first leak, then it appeared.

[Yaron, 2016-02-12 19:24:33]

lgtm

[agrieve, 2016-02-24 18:38:05]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-02-24 18:38:06]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1691993003/#ps40001
(title: "manifest tweaks")

[commit-bot: I haz the power, 2016-02-24 18:44:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1691993003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1691993003/40001

[commit-bot: I haz the power, 2016-02-24 19:53:51]

Description was changed from

==========
Hook up LeakCanary to ChromePublic.apk

It's currently hidden behind a GN arg: enable_leakcanary.
I hope to make it default to is_debug in the (near) future.

It just detects leaked Activities right now. I'll work on having
it detect other leaked Contexts next.

classes.dex size before change: 6090704
classes.dex size after change: 6090708

BUG=505909
==========

to

==========
Hook up LeakCanary to ChromePublic.apk

It's currently hidden behind a GN arg: enable_leakcanary.
I hope to make it default to is_debug in the (near) future.

It just detects leaked Activities right now. I'll work on having
it detect other leaked Contexts next.

classes.dex size before change: 6090704
classes.dex size after change: 6090708

BUG=505909
==========

[commit-bot: I haz the power, 2016-02-24 19:53:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-24 19:55:58]

Description was changed from

==========
Hook up LeakCanary to ChromePublic.apk

It's currently hidden behind a GN arg: enable_leakcanary.
I hope to make it default to is_debug in the (near) future.

It just detects leaked Activities right now. I'll work on having
it detect other leaked Contexts next.

classes.dex size before change: 6090704
classes.dex size after change: 6090708

BUG=505909
==========

to

==========
Hook up LeakCanary to ChromePublic.apk

It's currently hidden behind a GN arg: enable_leakcanary.
I hope to make it default to is_debug in the (near) future.

It just detects leaked Activities right now. I'll work on having
it detect other leaked Contexts next.

classes.dex size before change: 6090704
classes.dex size after change: 6090708

BUG=505909

Committed: https://crrev.com/dfec4d0d38ee352d967dabfe46e0a7727619ce02
Cr-Commit-Position: refs/heads/master@{#377356}
==========

[commit-bot: I haz the power, 2016-02-24 19:55:59]

Patchset 3 (id:??) landed as
https://crrev.com/dfec4d0d38ee352d967dabfe46e0a7727619ce02
Cr-Commit-Position: refs/heads/master@{#377356}