chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java - Issue 1697603002: Use LeakCanary for all Android Service instances

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java

Issue 1697603002: Use LeakCanary for all Android Service instances Base URL: https://chromium.googlesource.com/chromium/src.git@leak-canary-3

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/prerender/ChromePrerenderService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java b/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java

index e245d85c5f1a922e83fdfd851a12a902a5ff8e76..256b3bf1c1fdbed3dabf33dd8864d290cd4cc4ab 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java

@@ -14,6 +14,7 @@ import android.os.IBinder;

import android.os.PowerManager;

import android.os.PowerManager.WakeLock;

+import org.chromium.base.LeakCanaryUtil;

import org.chromium.base.Log;

import org.chromium.base.VisibleForTesting;

import org.chromium.base.annotations.SuppressFBWarnings;

@@ -108,6 +109,7 @@ public class PrecacheService extends Service {

releasePrecachingWakeLock();

super.onDestroy();

+ LeakCanaryUtil.watch(this);

}

@Override