CSS Typed OM: asMatrix for TransformComponent with LengthValue types

CSS Typed OM: asMatrix for TransformComponent with LengthValue types

Implement a naive isRelative() method in LengthValue subclasses.
This is then used in LengthValue::computeLengthPx.

As potentially a LengthValue might not be able to be resolved,
make TransfromComponent::asMatrix a method that can throw an exception.

This is behaviour is all tested using Perspective::asMatrix method.
Unfortunately, behaviour with percent type cannot be tested in
the Perspective class, so needs to be tested once Translation is
implemented.

LengthValue::computeLengthPx assumes that the viewport is not defined.
This needs to later be updated and is a very naive implementation.

BUG=545318

[tridgell, 2016-02-10 05:24:22]

tridgell@google.com changed reviewers:
+ eddye@chromium.org

[tridgell, 2016-02-10 05:24:42]

tridgell@google.com changed reviewers:
+ meade@chromium.org
- eddye@chromium.org

[meade_UTC10, 2016-02-11 00:56:29]

meade@chromium.org changed reviewers:
+ timloh@chromium.org

[meade_UTC10, 2016-02-11 00:56:30]

lgtm with a few nits

Adding Tim - PTAL soon Tim!

https://codereview.chromium.org/1689573002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/cssom/LengthValue.cpp (right):

https://codereview.chromium.org/1689573002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/cssom/LengthValue.cpp:73:
exceptionState.throwTypeError("Cannot resolve a relative unit to a pixel
value.");
Add a TODO to implement this?

https://codereview.chromium.org/1689573002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/cssom/PerspectiveTransformComponent.cpp
(right):

https://codereview.chromium.org/1689573002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/cssom/PerspectiveTransformComponent.cpp:5: 
Remove extra newline

https://codereview.chromium.org/1689573002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/cssom/PerspectiveTransformComponent.cpp:24:
return
MatrixTransformComponent::perspective(m_length->computeLengthPx(exceptionState));
Perhaps this should check for exceptionState.hadException before creating the
MatrixTransformComponent, and return nullptr if it had one.

[tridgell, 2016-02-12 04:22:28]

https://codereview.chromium.org/1689573002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/cssom/LengthValue.cpp (right):

https://codereview.chromium.org/1689573002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/cssom/LengthValue.cpp:73:
exceptionState.throwTypeError("Cannot resolve a relative unit to a pixel
value.");
On 2016/02/11 at 00:56:30, Eddy wrote:
> Add a TODO to implement this?

Done.

https://codereview.chromium.org/1689573002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/cssom/PerspectiveTransformComponent.cpp
(right):

https://codereview.chromium.org/1689573002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/cssom/PerspectiveTransformComponent.cpp:5: 
On 2016/02/11 at 00:56:30, Eddy wrote:
> Remove extra newline

Done.

https://codereview.chromium.org/1689573002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/cssom/PerspectiveTransformComponent.cpp:24:
return
MatrixTransformComponent::perspective(m_length->computeLengthPx(exceptionState));
On 2016/02/11 at 00:56:30, Eddy wrote:
> Perhaps this should check for exceptionState.hadException before creating the
MatrixTransformComponent, and return nullptr if it had one.

Done.  Also similarly implemented for TranslationTransformComponent.  The later
(in TranslationTransformComponent.cpp) uses only a single
exceptionState.hadException.  Should I add one after each property is
initialised?

[meade_UTC10, 2016-03-10 02:36:31]

Description was changed from

==========
CSS Typed OM: asMatrix for TransformComponent with LengthValue types

Implement a naive isRelative() method in LengthValue subclasses.
This is then used in LengthValue::computeLengthPx.

As potentially a LengthValue might not be able to be resolved,
make TransfromComponent::asMatrix a method that can throw an exception.

This is behaviour is all tested using Perspective::asMatrix method.
Unfortunately, behaviour with percent type cannot be tested in
the Perspective class, so needs to be tested once Translation is
implemented.

LengthValue::computeLengthPx assumes that the viewport is not defined.
This needs to later be updated and is a very naive implementation.

BUG=545318
==========

to

==========
CSS Typed OM: asMatrix for TransformComponent with LengthValue types

Implement a naive isRelative() method in LengthValue subclasses.
This is then used in LengthValue::computeLengthPx.

As potentially a LengthValue might not be able to be resolved,
make TransfromComponent::asMatrix a method that can throw an exception.

This is behaviour is all tested using Perspective::asMatrix method.
Unfortunately, behaviour with percent type cannot be tested in
the Perspective class, so needs to be tested once Translation is
implemented.

LengthValue::computeLengthPx assumes that the viewport is not defined.
This needs to later be updated and is a very naive implementation.

BUG=545318
==========

[meade_UTC10, 2016-03-10 02:36:31]

meade@chromium.org changed reviewers:
- timloh@chromium.org