third_party/WebKit/Source/core/css/cssom/StyleCalcLength.h - Issue 1689573002: CSS Typed OM: asMatrix for TransformComponent with LengthValue types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/StyleCalcLength.h

Issue 1689573002: CSS Typed OM: asMatrix for TransformComponent with LengthValue types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@asMatrixMethod

Patch Set: Add in Translation and use exceptionState.hadException Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/SkewTransformComponent.h ('k') | third_party/WebKit/Source/core/css/cssom/TransformComponent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/StyleCalcLength.h

diff --git a/third_party/WebKit/Source/core/css/cssom/StyleCalcLength.h b/third_party/WebKit/Source/core/css/cssom/StyleCalcLength.h

index d8a5fcfd6558e8e839018dd214adbf0c28619772..dddf4a57d2c54e96affd98e48c94ad915d284731 100644

--- a/third_party/WebKit/Source/core/css/cssom/StyleCalcLength.h

+++ b/third_party/WebKit/Source/core/css/cssom/StyleCalcLength.h

@@ -50,6 +50,19 @@ public:

bool containsPercent() const override;

+ bool isRelative() const override

+ {

+ return has(CSSPrimitiveValue::UnitType::Percentage)

+ || has(CSSPrimitiveValue::UnitType::Ems)

+ || has(CSSPrimitiveValue::UnitType::Exs)

+ || has(CSSPrimitiveValue::UnitType::Chs)

+ || has(CSSPrimitiveValue::UnitType::Rems)

+ || has(CSSPrimitiveValue::UnitType::ViewportWidth)

+ || has(CSSPrimitiveValue::UnitType::ViewportHeight)

+ || has(CSSPrimitiveValue::UnitType::ViewportMin)

+ || has(CSSPrimitiveValue::UnitType::ViewportMax);

+ }

PassRefPtrWillBeRawPtr<CSSValue> toCSSValue() const override;

StyleValueType type() const override { return CalcLengthType; }