Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 1689723004: CSS Typed OM: Implement TransformValue::asMatrix (Closed)

Created:
4 years, 10 months ago by tridgell
Modified:
3 years, 9 months ago
Reviewers:
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis, meade_UTC10
Base URL:
https://chromium.googlesource.com/chromium/src.git@computeLengthValue
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Typed OM: Implement TransformValue::asMatrix TransformValue::asMatrix returns: - the identity matrix (2d) when the components are empty - the multiplication of all the transform components in order Please note: - this is a very naive implementation Alternative improved approaches to consider: 1. Use switch statement and type casts. Have MatrixTransformComponent::multiplySelf take arguments TransformComponent and ExceptionState Then have a switch statement for each type and use the underlying TransformationMatrix operations, rather than unnecessarily making O(n) MatrixTransformComponents. It is also more optimised for operations such as scale etc where it only multiplies the necessary values, rather than the entire matrix. 2. Expose TransformValue to TransformationMatrix. Implement similar to 1. in TransformValue. Has the pro that MatrixTransformComponent could be kept as immutable. BUG=545318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.h View 3 chunks +13 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/TransformValue.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/TransformValue.cpp View 2 chunks +16 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/TransformValue.idl View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 2 (1 generated)
tridgell
4 years, 10 months ago (2016-02-12 05:21:06 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698