third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h - Issue 1689573002: CSS Typed OM: asMatrix for TransformComponent with LengthValue types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h

Issue 1689573002: CSS Typed OM: asMatrix for TransformComponent with LengthValue types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@asMatrixMethod

Patch Set: Add in Translation and use exceptionState.hadException Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/TransformComponent.idl ('k') | third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h

diff --git a/third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h b/third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h

index 30e29559dbdd68d4d41a9e004924a80fde3c55ff..f3243d8f43b809765e8f22f76d92d6afd7b1d9a7 100644

--- a/third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h

+++ b/third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h

@@ -29,8 +29,7 @@ public:

TransformComponentType type() const override { return is2D() ? TranslationType : Translation3DType; }

- // TODO: Implement asMatrix for TranslationTransformComponent.

- MatrixTransformComponent* asMatrix() const override { return nullptr; }

+ MatrixTransformComponent* asMatrix(ExceptionState&) const override;

PassRefPtrWillBeRawPtr<CSSFunctionValue> toCSSValue() const override;